Skip to content

ACL calculation, sampler thinned samples extraction#58

Open
Richard-Sti wants to merge 48 commits intocdcapano:masterfrom
Richard-Sti:acl_calculation
Open

ACL calculation, sampler thinned samples extraction#58
Richard-Sti wants to merge 48 commits intocdcapano:masterfrom
Richard-Sti:acl_calculation

Conversation

@Richard-Sti
Copy link
Collaborator

PR to add a classical ACL calculation and thinning sampler's samples.

@pep8speaks
Copy link

pep8speaks commented Apr 5, 2022

Hello @Richard-Sti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-22 20:11:25 UTC

@Richard-Sti
Copy link
Collaborator Author

Richard-Sti commented Apr 5, 2022

Possible further addition is to add the Gelmen-Rubin statistic.

Moreover, epsie's internal estimate of the ACL can potentially be used to introduce new sampler termination conditions until N independent samples are collected.

Blobs when thinning?

@Richard-Sti
Copy link
Collaborator Author

Richard-Sti commented Apr 5, 2022

Added the GH diagnostic for MH sampler. Need to check what is the best way to calculate it for the PT sampler.

@cdcapano please check the GH calculation.

@Richard-Sti Richard-Sti added the enhancement New feature or request label Apr 8, 2022
@Richard-Sti
Copy link
Collaborator Author

When thinning samples return the loglikegood and log prior, along with whatever the blobs are.

@Richard-Sti
Copy link
Collaborator Author

The German Rubin statistic sometimes produces values of < 1 for a PT sampler. Bug? Will fail tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants