fix(deno): set isDeno to false if version > 1.45.2 #23731
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we shouldn't use self. after Deno 1.45.3., based on their comment denoland/deno#24726 (comment), Deno had followed the NodeJs behavior.
In this PR, I added simple comparison from semver (compare major / minor / patch).
TODO:
something wrong happened in node-fetch, it stuck everytime......
The node-fetch seems not work well in deno. I'm gonna find another way to fix this.