Open
Conversation
eigenfoo
reviewed
Apr 2, 2019
| return tap | ||
|
|
||
|
|
||
| class Discriminator(nn.Module): |
Collaborator
There was a problem hiding this comment.
Why is the discriminator now in a separate module?
Owner
Author
There was a problem hiding this comment.
I felt like breaking it out of the main as i made it more complicated
ccurro
commented
Apr 3, 2019
|
|
||
| for layer in self.layers: | ||
| a = F.elu(a) | ||
| a = F.leaky_relu(layer(a), 0.2) |
Owner
Author
There was a problem hiding this comment.
Womp, I forgot to forward through the layer in this loop, so things were just being repeatedly activated, and it wasn't actually an mlp.
added 4 commits
April 3, 2019 07:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.