Skip to content

Added intra flag, removed duplicated call NO_JIRA #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

Conversation

pmbulit
Copy link
Member

@pmbulit pmbulit commented Apr 10, 2025

Added the option to ignore potential intramolecular HBonds and removed the duplicated call to get_mc_scores

Copy link
Contributor

@Alex-AMC Alex-AMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! looks like a good feature :)

Just a stylistic note, it won't make any massive difference

Copy link
Contributor

@maloney-ccdc maloney-ccdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have quibbled Alex's quibble

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@pmbulit pmbulit merged commit 2be0c35 into main Apr 15, 2025
4 of 5 checks passed
@pmbulit pmbulit deleted the intra_flag branch April 15, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants