Skip to content

Check for JIRA ID or "no jira" marker in commit message. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 20, 2021
Merged

Check for JIRA ID or "no jira" marker in commit message. #9

merged 10 commits into from
Apr 20, 2021

Conversation

siong-chin
Copy link
Contributor

No description provided.

@siong-chin siong-chin self-assigned this Apr 19, 2021
@siong-chin siong-chin force-pushed the jira_bld_5704_jira_id_in_commit_message branch from 0bb0481 to f7a6730 Compare April 19, 2021 18:39
@siong-chin siong-chin force-pushed the jira_bld_5704_jira_id_in_commit_message branch from bfc5e27 to 802c1c2 Compare April 19, 2021 21:02
@siong-chin siong-chin force-pushed the jira_bld_5704_jira_id_in_commit_message branch from 802c1c2 to b8f9b0c Compare April 19, 2021 21:09
MatthewT123
MatthewT123 requested changes Apr 20, 2021
View reviewed changes
MatthewT123
MatthewT123 approved these changes Apr 20, 2021
View reviewed changes
Copy link

@MatthewT123 MatthewT123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Ironically the files here are failing the pre commit checks, which is probably unavoidable - unless you change the code to concatenate two strings to make up the DO NOT MERGE text, so that the code here can itself pass the check .

@siong-chin siong-chin merged commit 36d76a9 into main Apr 20, 2021
@siong-chin siong-chin deleted the jira_bld_5704_jira_id_in_commit_message branch April 20, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewT123 MatthewT123 MatthewT123 approved these changes

@rockdreamer rockdreamer Awaiting requested review from rockdreamer

Assignees

@siong-chin siong-chin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siong-chin @MatthewT123