-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deal with () in filenames by escaping them (NO_JIRA) #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonccole
commented
Mar 13, 2025
jasonccole
commented
Mar 13, 2025
…d file nastiness (NO_JIRA)
jasonccole
commented
Mar 14, 2025
…rror to propagate rather than catching (NO_JIRA)
siong-chin
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few f-strings no longer needed. Otherwise should be fine.
Will remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should 'escape' file names when calling subprocess commands so that they dont fall down on linux platforms (as is currently happening in this PR) for filenames containing certain characters:
See: https://github.com/ccdc-confidential/cpp-apps-main/actions/runs/13816850366/job/38652179948?pr=4142
I'd appreciate a careful check - seems to work on my machine, but I've no easy way to test it in the 'live' repo.
Ironically the PR fails in checks ... because of the python version :-}
Update: PR now works since I've changed the python version in the PR. Horribly self-referential!
Update 2: following a chat with Simon & Matt - I've changed it so that we instead use subprocess without Shell=True - this should resolve the syntactic issues with files