HelpersTask597_Configure_Codecov_for_coverage #598
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
dev_scripts_helpers/update_devops_packages/notebooks/Master_buildmeister_dashboard.ipynb
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/update_devops_packages/notebooks/Master_buildmeister_dashboard.ipynb
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/update_devops_packages/notebooks/Master_buildmeister_dashboard.py
Show resolved
Hide resolved
…b.com:causify-ai/helpers into HelpersTask597_Configure_Codecov_for_coverage
…b.com:causify-ai/helpers into HelpersTask597_Configure_Codecov_for_coverage
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| submodules: true |
There was a problem hiding this comment.
Let's change it to submodules: recursive to prepare for using it as a reusable workflow.
| # Scheduled for Monday (i.e Day 1) or when manually triggered. | ||
| if: (github.event_name == 'schedule' && env.DAY_OF_WEEK == '1') || github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
It's looking a bit hackish. Let's add a TODO to consider removing it when we turn this workflow into a reusable one.
| run: invoke run_superslow_coverage . | ||
|
|
||
| - name: Upload Superslow Test Coverage to Codecov | ||
| if: (github.event_name == 'schedule' && env.DAY_OF_WEEK == '1') || github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
I'd not duplicate the if here, just use
https://stackoverflow.com/questions/60453924/running-a-github-actions-step-only-if-previous-step-has-run
Something like:
- name: Build app
id: build
run: |
<build command>
- name: Run tests
- name: Create artifact of test coverage
if: steps.build.outcome == 'success'
| """ | ||
| Run coverage for a given suite (fast/slow/superslow). | ||
|
|
||
| :param suite: one of "fast" or "slow" |
There was a problem hiding this comment.
Let's add the superslow also.
| :param generate_html_report: whether to produce HTML output | ||
| :return: xml file named 'coverage.xml' | ||
| """ | ||
|
|
| hlitauti.run(ctx, test_cmd, use_system=False) | ||
| # Move the default ".coverage" file to our suite-specific filename. | ||
| hsystem.system(f"mv .coverage {coverage_file}") | ||
| hdbg.dassert_file_exists(coverage_file) |
There was a problem hiding this comment.
I'd check the existence of .coverage before renaming.
| # Move the default ".coverage" file to our suite-specific filename. | ||
| hsystem.system(f"mv .coverage {coverage_file}") | ||
| hdbg.dassert_file_exists(coverage_file) | ||
| # Compute which files/dirs to include and omit in the report. |
There was a problem hiding this comment.
I'm lost. What report do you meant here?
There was a problem hiding this comment.
Probably it worth to split the pipeline to blocks with comments.
| report_cmd: List[str] = [ | ||
| # Clear out any prior coverage data. | ||
| "coverage erase", | ||
| # Combine this suite's data into the coverage database. |
There was a problem hiding this comment.
Again, I'm puzzled. Why we need it?
| # Export XML coverage report. | ||
| report_cmd.append("coverage xml -o coverage.xml") | ||
| full_report_cmd: str = " && ".join(report_cmd) | ||
| docker_cmd_ = f"invoke docker_cmd --use-bash --cmd '{full_report_cmd}'" |
There was a problem hiding this comment.
Dumb question: why we need to run it inside the Docker container?
| return include_in_report, exclude_from_report | ||
|
|
||
|
|
||
| def _run_coverage( |
There was a problem hiding this comment.
Can we promote it to an invoke target and get rid of:
- run_fast_coverage
- run_slow_coverage
- run_superslow_coverage
WDYT?
Issue: #597