chore: improve testing #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vdbe
commented
Sep 15, 2024
vdbe
commented
- fail tests if test scripts exit's with none 0 code
- don't expand option by default
- check all if colors are expanded
- check if module text is not expanded
vdbe
commented
Sep 15, 2024
Comment on lines
+13
to
+17
| print_option @catppuccin_status_application | grep -q "$application_text" || | ||
| echo "@catppuccin_status_application expanded @catppuccin_application_text more than once" | ||
|
|
||
| print_option @catppuccin_status_application | grep -q "@thm_" && | ||
| echo "@catppuccin_status_application did not expand all colors" |
There was a problem hiding this comment.
maybe add a die function in helpers that takes a msg and exit's with 1?
currently it fails on diff with expected
- fail tests if test scripts exit's with none 0 code - don't expand option by default - check all if colors are expanded - check if module text is not expanded
vdbe
force-pushed
the
chore/tmux-native/improve-testing
branch
from
58f1029
to
76a7b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.