Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add icon separator if there is no icon for a status module #265

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

j-xella
Copy link
Contributor

@j-xella j-xella commented Aug 3, 2024

When rendering status modules, there is a separator between the icon and the module text. Before, it was redundantly shown even when the module icon was disabled by the user.

Copy link
Contributor

@vdbe vdbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better way to do this is before the echo check if an icons is empty and clear $show_icon if so

if [ -z "$icon] ; then
  show_icon=""
fi

@j-xella
Copy link
Contributor Author

j-xella commented Aug 4, 2024

Reimplemented, please have a look

@j-xella
Copy link
Contributor Author

j-xella commented Aug 6, 2024

It could possibly fix #85

@vdbe vdbe merged commit df23892 into catppuccin:main Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants