Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability of benchmark-based CPU throttle scaling #644

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Nov 8, 2023

This puts a limit on the maximum scale that will be applied to CPU throttling (defaults to 2) as well as records the benchmark results for the last 9 benchmarks (9 hours of agent running usually) and picks the median result so that benchmark outliers don't skew the CPU throttling.

@mjkozicki mjkozicki self-assigned this Nov 30, 2023
@pmeenan pmeenan closed this Dec 4, 2023
@pmeenan pmeenan deleted the throttle branch December 4, 2023 16:03
@claud-io
Copy link
Contributor

@pmeenan any reason for which this is closed? was not working as expected?

@pmeenan
Copy link
Contributor Author

pmeenan commented Feb 27, 2024

It's working as expected and we have deployed it in the HTTP Archive. I've had a few PR's that weren't getting any traction so I assumed it was no longer being actively maintained. If that's not the case, I'm happy to restore it and reopen the PR.

@claud-io claud-io changed the base branch from master to qa February 29, 2024 11:15
@claud-io claud-io changed the base branch from qa to master April 11, 2024 07:53
@mjkozicki mjkozicki merged commit 9c0c533 into catchpoint:master Apr 17, 2024
2 checks passed
@pmeenan pmeenan deleted the throttle branch April 23, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants