Skip to content

Issues/45: Make reengagement respect the "suppress target" setting during cron #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abautu wants to merge 1 commit into
base: MOODLE_405_STABLE
Choose a base branch
from
Open

Issues/45: Make reengagement respect the "suppress target" setting during cron #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,11 @@ function reengagement_crontask() {
FROM {reengagement_inprogress} ri
JOIN {reengagement} r ON r.id = ri.reengagement
JOIN {user} u ON u.id = ri.userid
LEFT JOIN {course_modules_completion} cmc ON cmc.userid = u.id AND cmc.coursemoduleid = r.suppresstarget
WHERE u.deleted = 0 AND
completiontime < ? AND completed = 0';
$inprogresses = $DB->get_recordset_sql($inprogresssql, array($timenow));
ri.completed = 0 AND
(completiontime < ? OR cmc.completionstate IN (?,?,?))';
$inprogresses = $DB->get_recordset_sql($inprogresssql, array($timenow, COMPLETION_COMPLETE, COMPLETION_COMPLETE_PASS, COMPLETION_COMPLETE_FAIL));
$completeripcount = 0;
foreach ($inprogresses as $inprogress) {
$completeripcount++;
Expand Down