Update facetoface.php - fix default messages templates#279
Open
Vozsvarozs wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
Open
Update facetoface.php - fix default messages templates#279Vozsvarozs wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
Vozsvarozs wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
Conversation
The current default message templates include the venue, location and/or room fields, though those fields do not exist by default anymore. So unless admins create them, or users remove them from each and every instance by changing the default notifications, the messages sent will contain those and display meaningless lines. This is more problematic for cases when the plugin is translated, as the expressions for those placeholders are not included in the lang file, putting additional burden on admins to solve this. So removing those lines from the message template could solve this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current message templates include the
venue,locationand/orroomfields for the sessions, but those fields are not included in the plugin by default anymore. They need to be added as custom session fields if one wants to use them.Unless admins create them, update the local language packs or have users (teachers, managers) remove those from each and every F2F session instance by updating the notification messages, the emails sent will contain those and display meaningless lines (like in issue #105).
This is more problematic when the plugin is used in other languages, as the expressions for those placeholders are not included in the language pack. So either the EN custom fields are created. which might cause confusion for users, or some other workaround is needed to solve this.
Removing those lines from the default message templates could solve this issue.