Skip to content

Conversation

@cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Jan 28, 2025

Overview

Closes #518.

What problem does this address?

What did you change in this PR?

  • grabs the building characteristics, the consumption, microdata and the methodology

Testing

How did you make sure this worked? How can a reviewer verify this?
https://zenodo.org/records/14782474
https://sandbox.zenodo.org/records/161000

To-do list

- [ ] add other TODO items here if necessary! questions that need to answered, decisions that need to be made, tests that need to be run, etc.
- [ ] Update relevant documentation - like comments, docstrings, README, release notes, etc.
- [ ] Review the PR yourself and call out any questions or issues you have

@cmgosnell cmgosnell self-assigned this Jan 28, 2025
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job handling a really complex dataset. I spot checked 2018, 2012 and 1999 files to make sure nothing was missing.

Approving because all my feedback won't affect the archives, and is mostly for clarity / legibility. (Presuming you'll check SAS files are downloaded as expected before you publish, that's the only thing that was missing when I ran this!)

cmgosnell and others added 3 commits January 31, 2025 11:57
Co-authored-by: E. Belfer <[email protected]>
@cmgosnell cmgosnell enabled auto-merge January 31, 2025 19:13
@cmgosnell cmgosnell merged commit abe25f9 into main Jan 31, 2025
3 checks passed
@cmgosnell cmgosnell deleted the eiacbecs branch January 31, 2025 19:34
@e-belfer e-belfer added the eiacbecs EIA CBECS data label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eiacbecs EIA CBECS data

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Write an archiver for EIA Commercial Buildings Energy Consumption Survey

3 participants