Fix x/y translation misses from ViewPager.java#18
Open
journeymansix wants to merge 7 commits intocastorflex:masterfrom
Open
Fix x/y translation misses from ViewPager.java#18journeymansix wants to merge 7 commits intocastorflex:masterfrom
journeymansix wants to merge 7 commits intocastorflex:masterfrom
Conversation
…oll within a list before scrolling the pager's page
…p of the scrollable container and first page, and the oposite of course
|
any chance we can get this merged in? |
|
@castorflex Please do merge this and update the aar @ jcenter. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a couple of places where the translation from x to y was apparently missed in the copy/modify from ViewPager.java. I also updated a couple of code comments similarly. Lastly, I removed the cast to (View) in debugging statements, which was causing invalid cast errors for me, and apparently isn't necessary.