Feat/import export roles

[omaraelhawary]

Related to #115

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request implements role import and export features, enabling the transfer of roles and settings via JSON. It adds dedicated classes for these operations, a preview-based import workflow, and updates the admin UI to support bulk exports and provide clearer status for non-editable roles. Feedback identifies a potential data loss bug in the settings import logic, redundant code in role updates, and a need for more robust sanitization of imported settings.

[gemini-code-assist]

Code Review

This pull request implements a role import and export system for the Members plugin, enabling the transfer of roles and settings via JSON files. It introduces new classes for handling these processes, adds bulk export functionality to the roles list table, and provides a two-step import interface with conflict resolution options. Technical feedback identifies redundant manual updates to the global roles object and recommends more robust sanitization for imported settings using map_deep to handle complex data structures.

[cartpauj]

@omaraelhawary will you feed the Gemini feedback into Claude or Cursor (whichever you're using)?

I find it's helpful to tell it

Below is some feedback from Gemini AI code review in github. Please look through the code and assess if these feedback items really need to be addressed/resolved or not. Please let me know what you've decided before you fix these issues and we'll make a plan together.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a role import and export system for the Members plugin, enabling JSON-based migration of roles and settings. It features a two-step import process with conflict resolution and updates the admin UI with bulk export actions and improved feedback for non-editable roles. Feedback identifies several technical improvements: preventing accidental lockouts by restricting role overwrites, ensuring administrative dependencies are loaded, adding data validation for imported roles, and maintaining consistency with the plugin's internal role registry.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces role export and import functionality to the Members plugin, allowing users to transfer roles and settings between sites via JSON files. Key additions include the Role_Export and Role_Import classes, a two-step import workflow with a preview stage, and updates to the roles list table to support bulk export actions and improved UI for non-editable roles. The review feedback suggests hardening the singleton implementation by making constructors private, ensuring required WordPress admin files are explicitly loaded before calling get_plugin_data, and adding a safety check during the final import step to verify role existence and prevent accidental overwrites of roles created between the preview and confirmation phases.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces comprehensive role export and import functionality, enabling the transfer of roles and plugin settings via JSON files. It adds dedicated classes for export and import logic, a preview-based import workflow with conflict resolution, and UI enhancements to the roles list table for bulk actions and role status visibility. A performance optimization was suggested for the import confirmation process to avoid redundant function calls within a loop.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a comprehensive role import and export system, allowing users to transfer roles and plugin settings between sites via JSON files. The implementation includes a two-step import workflow with conflict detection and bulk export functionality. Key feedback includes strengthening security by preventing the overwrite of uneditable roles during import, improving data validation for settings to avoid PHP notices, and optimizing performance in the role list table by using cached properties instead of repeated option lookups.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces role import and export functionality to the Members plugin, allowing users to transfer roles and settings between sites via JSON files. Key additions include new Role_Export and Role_Import classes, a two-step import workflow with conflict detection, and updates to the roles list table to support bulk export actions. Review feedback suggests strengthening security by explicitly protecting the 'administrator' role from being overwritten, refining the settings import logic to ensure data integrity, and moving large inline scripts to a dedicated file for improved maintainability.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces functionality to export and import user roles and plugin settings via JSON files. The changes include new classes for handling export and import logic, updates to the roles list table to support bulk export, and UI enhancements for managing imports. My feedback suggests optimizing the plugin version retrieval to avoid expensive file parsing and moving the newly added inline CSS and JavaScript into external files to improve maintainability and performance.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces comprehensive role import and export functionality to the Members plugin, allowing users to transfer roles and settings between WordPress sites via JSON files. The implementation includes a new export class, a two-step import process with preview and conflict resolution, and UI updates to the roles management page. I have reviewed the code and identified two areas for improvement: adding type casting for the role label to prevent potential PHP warnings, and centralizing the protection logic for critical roles to ensure they cannot be inadvertently modified during any import action.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request implements a role import and export system, allowing users to transfer roles and settings via JSON files. It features a two-step import process with conflict detection, selective bulk exports, and updated UI components including a preview page and help tabs. The review feedback suggests enhancing the robustness of the import logic by checking file read results and using standard boolean validation for capabilities, as well as improving translation strings by separating HTML from translatable text.

[omaraelhawary]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a robust role import and export system, allowing users to transfer roles and plugin settings between sites via JSON files. Key additions include the Role_Export and Role_Import classes, a two-step import workflow with conflict detection, and UI enhancements to the roles list table for bulk actions and protected role visibility. Review feedback suggests tightening the enforcement of protected roles during the import process and adding error handling to the role overwrite logic to ensure system consistency if role creation fails.

[omaraelhawary]

@ThemeGravity Ready to review. Thanks in advance. Here's a description about it:

Import / Export Roles — Feature Summary

Overview

This feature adds the ability to export and import WordPress roles (and optionally plugin settings) via JSON files on the Members plugin Roles admin screen (Members > Roles). It enables transferring role configurations between WordPress sites.

Export

• "Export All" button in the page header downloads a JSON file containing all roles, their capabilities, and Members plugin settings. Requires list_roles capability.
• Bulk "Export" action in the list table lets the user select specific roles via checkboxes. The exported file includes only the selected roles and omits plugin settings.
• The JSON file includes a meta block (plugin, version, export_date, site_url, wp_version), a roles map, and a settings object (full export only).

Import (Two-Step Flow)

Step 1 — Upload & Preview

• User clicks "Import" to reveal a slide-down panel with a file input and an optional "Also import Members plugin settings" checkbox.
• On submit, the file is validated (must be .json, under 2 MB, valid JSON, correct meta.plugin marker, at least one valid role).
• Role slugs are sanitized; duplicates caused by sanitization are detected and counted.
• Each role is checked against existing roles for conflict detection.
• Parsed data is stored in a user-specific transient (30 min TTL) and the user is redirected to a preview page.

Step 2 — Preview & Confirm

• Preview page shows a table with each role's name, slug, capability count (expandable), status ("New" / "Exists"), and an action dropdown.
• For new roles: Import or Skip.
• For existing (conflicting) roles: Skip, Overwrite, or Import as new (rename).
• For protected roles (administrator, current user's role, default role, non-editable): forced to Skip.
• A "Set all conflicts to" bulk dropdown applies Skip or Overwrite to all conflict rows at once.
• On confirm, the transient is consumed, roles are created/overwritten/renamed per selection, capabilities are sanitized, and settings are optionally merged.
• A summary message is shown (e.g., "3 roles imported. 2 roles skipped. Plugin settings imported.").

Security

• All forms use nonce verification.
• Export requires list_roles; import requires edit_roles.
• Capabilities are sanitized via members_sanitize_cap(); role slugs via members_sanitize_role().
• Imported settings are filtered against known default keys only — no arbitrary options can be injected.
• Protected roles (administrator, current user's own role, site default role) cannot be overwritten.