feat: initialize transactionMu in NewAdapterByDBUseTableName #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
constructor NewAdapterByDBUseTableName should initialize transactionMu, otherwise it will ~~panic~~ blocked due to that cas when calling Transaction Besides, a few other constructors also depend on NewAdapterByDBUseTableName, if transactionMu is not initialized in NewAdapterByDBUseTableName, it will blocked as well. Besides, why not consider use sync.Once to initialize transactionMu?
|
pretty similar to #236 actually i just hoping to initialize that transactionMu asap, otherwise my current code will totally blocked in that CAS loop... |
MuZhou233
approved these changes
May 31, 2024
hsluoyz
changed the title
|
🎉 This PR is included in version 3.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constructor NewAdapterByDBUseTableName should initialize transactionMu,
otherwise it will
panicblocked due to that CAS when calling TransactionBesides, a few other constructors also depend on NewAdapterByDBUseTableName,
if transactionMu is not initialized in NewAdapterByDBUseTableName,
it will blocked as well.
Besides, why not consider use sync.Once to initialize transactionMu?