feat: initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmvaldivia
added
documentation
jcrqr
suggested changes
Jun 9, 2022
README.md
Outdated
| - AWS AppConfig Application should exist already | ||
| - AWS Appconfig Application Configuration profile should exist already | ||
| - AWS AppConfig Environment should exist already | ||
|
|
README.md
Outdated
Comment on lines
25
to
26
|
|
||
|
|
aws/aws.go
Outdated
| return string(output.Configuration), nil | ||
| } | ||
|
|
||
| func awsSdkConfig(region string) (aws.Config, error) { |
There was a problem hiding this comment.
Consider adding a context.Context argument here and pass the same context used for the other AWS functions.
There was a problem hiding this comment.
sounds reasonable
aws/aws.go
Outdated
| "github.com/aws/aws-sdk-go-v2/service/appconfigdata" | ||
| ) | ||
|
|
||
| func GetConfig(appName, profileName, env, region string) (string, error) { |
There was a problem hiding this comment.
Consider adding a context.Context here that can be passed by the calling code and re-used in every AWS function (better if we ever decide to do something we the context we can do it in the main file instead of having to update multiple places).
There was a problem hiding this comment.
sounds reasonable
Co-authored-by: João Cerqueira <[email protected]>
…-fetch-action into feat/init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New action to fetch AWS appconfig configuration