test: add vi fixtures#51
Conversation
twocaretcat
left a comment
twocaretcat
left a comment
There was a problem hiding this comment.
Thanks for the PR! The tests are mostly correct, but the inputs don't match what is used for other languages. Sorry if that requirement was unclear. If you're able to replace the input text and regenerate the fixture outputs that would be great.
There was a problem hiding this comment.
This input uses different source text from the other languages. Each language must translate the same input so the tests remain comparable. Please use “Xin chúc mừng!”, matching the English fixture. Copy its source/license comments, then regenerate the fixture outputs.
There was a problem hiding this comment.
This input uses different source text from the other languages. Each language must translate the same input so the tests remain comparable. Please use “Tôi nhớ bạn”, matching the English fixture. Copy its source/license comments, then regenerate the fixture outputs.
There was a problem hiding this comment.
This input uses different source text and contains two sentences, while this case should contain one sentence with punctuation. Each language must translate the same input so the tests remain comparable. Please use the corresponding Vietnamese translation, matching the English fixture. Copy its source/license comments, then regenerate the fixture outputs.
There was a problem hiding this comment.
This input uses different source text from the other languages. Each language must translate the same input so the tests remain comparable. There's no existing translation for this one, so please translate the text in the English fixture into Vietnamese yourself. Copy its source/license comments, then regenerate the fixture outputs.
There was a problem hiding this comment.
This input uses different source text from the other languages. Each language must translate the same input so the tests remain comparable. Please use Articles 3 and 4 from the official Vietnamese UDHR translation, matching the English fixture. Keep the blank line between the articles, copy the English file’s source comment, then regenerate the fixture outputs.
2 participants
add Vietnamese fixtures for segmentation tests
closes #11
covers: