Conversation
## Description As reported by API user, the proposal_voting_summary endpoint was reporting over 50% yes for pools votes for most recent HardForkInitiation proposals, when in fact more accurate total is in the 30s - due to 'always_abstain' logic not being supposedly applicable for hard fork gov actions (i.e. even if pool's reward address is delegating to always_abstain predefined Drep, unless they actively vote they are counted as 'no' voting power) ## Which issue it fixes? <!--- Link to issue: Closes #issue-number -->
Only join on latest committee registration record; disregard resigned members when calculating total committee size Follows a report from API user that current data for a proposal like ratified Tweag one is showing incorrect values both for numerator and denominator used in calculating the 'yes' % for committee
Epoch is moving from table to view, so relocating previous trigger to epoch_state table; added extra block of logic to cater for simplistic pool schedule retirement actions. Will also use this PR to correct return data type on epoch_no in proposal_voting_summary function ## Description <!--- Describe your changes --> ## Which issue it fixes? <!--- Link to issue: Closes #issue-number -->
## Description Due to performance issues with new 'epoch' view, changes to utilize max(epoch_no) from epoch_param instead --------- Co-authored-by: Greg Beresnev <greg.beresnev@yarris.com>
#410) …ed extra index on voting_procedure to help with performance issue observed on preprod ## Description <!--- Describe your changes --> ## Which issue it fixes? <!--- Link to issue: Closes #issue-number --> Co-authored-by: hodlonaut <hodlonaut@github.com>
Extra index to speed up proposal voting summary calculations (helps non-treasury withdrawal proposals the most seemingly using mainnet data)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Koios Release v1.4.2 updates