-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React|WC Parity: Link #18443
React|WC Parity: Link #18443
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18443 +/- ##
=======================================
Coverage 84.15% 84.16%
=======================================
Files 408 408
Lines 14443 14450 +7
Branches 4641 4696 +55
=======================================
+ Hits 12155 12162 +7
+ Misses 2124 2123 -1
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @guidari, the changes look solid!
I have a few observations and wanted to confirm with you as well:
-
Are we planning to add a 'Table of Contents' to the Web Components website too?
-
I wanted to check on the responsiveness of the Web Components website. I’ve shared a video where an extra blank box appears—I've highlighted it with the cursor for clarity.
Screen.Recording.2025-01-30.at.5.14.26.PM.mov
Let me know your thoughts!
Good question @Kritvi-bhatia17. I see we have a lot of PRs open already, and from what I've seen they don't have the "Table of contents", I guess it might be good to add. However we would have to add to all the PRs to have parity.
That seems to be an issue, like a sev 3 or 4. |
I’ve noticed the same, but I’m not sure about the priority for this. Maybe @tay1orjones or @sstrubberg can help with that? Rest, all looks good to me! 🚀 |
21d0e46
Closes #17924
Link - React and Web Components parity
Changelog
Changed
Changed
Testing / Reviewing