Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React|WC Parity: Link #18443

Merged
merged 2 commits into from
Jan 31, 2025
Merged

React|WC Parity: Link #18443

merged 2 commits into from
Jan 31, 2025

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 27, 2025

Closes #17924

Link - React and Web Components parity

Changelog

Changed

  • Changed the overview docs to match React on text
  • Changed Paired With Icon variant to match React
  • Added controls to Default story

Changed

  • Removed Playground story

Testing / Reviewing

  • CI should pass
  • Component should work as expected

@guidari guidari requested a review from a team as a code owner January 27, 2025 17:15
@guidari guidari requested review from alisonjoseph, tay1orjones, a team and alina-jacob and removed request for a team January 27, 2025 17:15
@guidari guidari changed the title feat: parity work with carbon react React|WC Parity: Link Jan 27, 2025
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b46a42e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/679cd631a65949000998a69f
😎 Deploy Preview https://deploy-preview-18443--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b46a42e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/679cd631a76d9200089ac10a
😎 Deploy Preview https://deploy-preview-18443--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones requested review from annawen1 and removed request for alisonjoseph January 27, 2025 17:24
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b46a42e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/679cd6310cd1fe00084a6d38
😎 Deploy Preview https://deploy-preview-18443--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (eee39f8) to head (b46a42e).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18443   +/-   ##
=======================================
  Coverage   84.15%   84.16%           
=======================================
  Files         408      408           
  Lines       14443    14450    +7     
  Branches     4641     4696   +55     
=======================================
+ Hits        12155    12162    +7     
+ Misses       2124     2123    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@guidari guidari added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 30, 2025
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guidari, the changes look solid!

I have a few observations and wanted to confirm with you as well:

  1. Are we planning to add a 'Table of Contents' to the Web Components website too?

    image
  2. I wanted to check on the responsiveness of the Web Components website. I’ve shared a video where an extra blank box appears—I've highlighted it with the cursor for clarity.

    Screen.Recording.2025-01-30.at.5.14.26.PM.mov

    image

Let me know your thoughts!

@guidari
Copy link
Contributor Author

guidari commented Jan 30, 2025

Are we planning to add a 'Table of Contents' to the Web Components website too?

Good question @Kritvi-bhatia17. I see we have a lot of PRs open already, and from what I've seen they don't have the "Table of contents", I guess it might be good to add. However we would have to add to all the PRs to have parity.

I wanted to check on the responsiveness of the Web Components website. I’ve shared a video where an extra blank box appears—I've highlighted it with the cursor for clarity.

That seems to be an issue, like a sev 3 or 4.

@Kritvi-bhatia17
Copy link
Contributor

Are we planning to add a 'Table of Contents' to the Web Components website too?

Good question @Kritvi-bhatia17. I see we have a lot of PRs open already, and from what I've seen they don't have the "Table of contents", I guess it might be good to add. However we would have to all the PRs to have parity.

I’ve noticed the same, but I’m not sure about the priority for this. Maybe @tay1orjones or @sstrubberg can help with that?


Rest, all looks good to me! 🚀

@guidari guidari added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@guidari guidari added this pull request to the merge queue Jan 31, 2025
Merged via the queue into carbon-design-system:main with commit 21d0e46 Jan 31, 2025
37 checks passed
@guidari guidari deleted the 17924-link branch January 31, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Link
5 participants