-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: controlled combobox with downshiftProps #18441
base: main
Are you sure you want to change the base?
fix: controlled combobox with downshiftProps #18441
Conversation
ensure onChange is called when downshiftProps & onStateChange is provided
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18441 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 408 408
Lines 14449 14450 +1
Branches 4696 4666 -30
=======================================
+ Hits 12161 12162 +1
+ Misses 2124 2123 -1
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
Closes #18212
ensure onChange is called when downshiftProps & onStateChange is provided
Changelog
Changed
testing
args
in the_fullyControlled
example in ComboBox.stories.js (you need to do this to see console.logs for some reason)downshiftProps
withonStateChange
to the props of the ComboBoxie.
onStateChange
and the function provided toonChange
are firing.