Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(experimental): improve the move to stable checklist #18401

Merged

Conversation

tay1orjones
Copy link
Member

This spawned from a team meeting we had today to update this checklist to have greater detail about the React|WC implementation. I also improved the formatting so it's easier to copy/paste and digest the content.

Changelog

Changed

  • add more detail to the move to stable checklist

Testing / Reviewing

@tay1orjones tay1orjones requested a review from a team as a code owner January 22, 2025 15:57
@tay1orjones tay1orjones requested review from alisonjoseph, ariellalgilmore and kennylam and removed request for ariellalgilmore January 22, 2025 15:57
@tay1orjones tay1orjones self-assigned this Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cb32069
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6791157f673f8500080b7534
😎 Deploy Preview https://deploy-preview-18401--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit cb32069
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6791157f05e48100087d14f6
😎 Deploy Preview https://deploy-preview-18401--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit cb32069
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6791157f036f2300088f326b
😎 Deploy Preview https://deploy-preview-18401--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c273aa8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67a3b04ec893e80008654903
😎 Deploy Preview https://deploy-preview-18401--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c273aa8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67a3b04eb3e4510008e6d76c
😎 Deploy Preview https://deploy-preview-18401--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c273aa8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67a3b04e630f4200081f6b13
😎 Deploy Preview https://deploy-preview-18401--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (d975d04) to head (c273aa8).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18401      +/-   ##
==========================================
- Coverage   84.16%   84.10%   -0.07%     
==========================================
  Files         408      408              
  Lines       14450    14466      +16     
  Branches     4696     4676      -20     
==========================================
+ Hits        12162    12166       +4     
- Misses       2124     2133       +9     
- Partials      164      167       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tay1orjones and others added 4 commits January 24, 2025 14:48
Co-authored-by: Alison Joseph <[email protected]>
…date-stable-checklist
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And yes, let's add the WC stuff in another PR. We can review the wording with the team on how experimental/stable is handled for WC.

@tay1orjones tay1orjones added this pull request to the merge queue Feb 6, 2025
Merged via the queue into carbon-design-system:main with commit fb4f8f5 Feb 6, 2025
37 checks passed
@tay1orjones tay1orjones deleted the update-stable-checklist branch February 6, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants