-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove loading animation in inlineloading inactive state #17814
base: main
Are you sure you want to change the base?
fix: remove loading animation in inlineloading inactive state #17814
Conversation
Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 2 out of 3 committers have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17814 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 406 406
Lines 14046 14050 +4
Branches 4354 4375 +21
=======================================
+ Hits 11400 11404 +4
+ Misses 2480 2479 -1
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove the .history
files from the PR? I believe that is generated by VS Code right? it may also be worth adding .history
to the .gitignore
as well
This reverts commit 5e7e769.
…m:dedanade/carbon into inlineloaing-remove-animation-in-inactive
Hi @emyarod, Thanks for the heads up. This has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the above discussion, removing the loading animation and the space for in-active state makes sense, so good to go! 🚀
Closes #17793
This is to Fix the bug of loading animation visible beside the title when
inlineloading
is in aninactive
status.Changelog
Changed
if
condition of an active and inactive state.classname
to the title of an inactive state following other classname guidelines.expect
newclassname
to be in the Document.Removed
Testing / Reviewing
From the Story board, switch the status from 'finished' to 'inactive'. The loading animation will not show and we have a static text.