Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove loading animation in inlineloading inactive state #17814

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dedanade
Copy link
Contributor

Closes #17793

This is to Fix the bug of loading animation visible beside the title when inlineloading is in an inactive status.

Changelog

Changed

  • I separated the if condition of an active and inactive state.
  • I added a new classname to the title of an inactive state following other classname guidelines.
  • I changed the test cases to expect new classname to be in the Document.

Removed

  • Nothing

Testing / Reviewing

From the Story board, switch the status from 'finished' to 'inactive'. The loading animation will not show and we have a static text.

@dedanade dedanade requested a review from a team as a code owner October 20, 2024 22:10
Copy link
Contributor

github-actions bot commented Oct 20, 2024

Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


2 out of 3 committers have signed the DCO.
✅ (dedanade)[https://github.com/dedanade]
✅ (alisonjoseph)[https://github.com/alisonjoseph]
@daniel Adebonojo
Daniel Adebonojo seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 6bcd4e2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67226c60188cd40008bd4630
😎 Deploy Preview https://deploy-preview-17814--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 983d219
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67157fe976630100083da1e2
😎 Deploy Preview https://deploy-preview-17814--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6bcd4e2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67226c6084a483000801235a
😎 Deploy Preview https://deploy-preview-17814--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 6bcd4e2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67226c608c9e430008bf88f6
😎 Deploy Preview https://deploy-preview-17814--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (75c827d) to head (6bcd4e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17814   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         406      406           
  Lines       14046    14050    +4     
  Branches     4354     4375   +21     
=======================================
+ Hits        11400    11404    +4     
+ Misses       2480     2479    -1     
- Partials      166      167    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dedanade
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the .history files from the PR? I believe that is generated by VS Code right? it may also be worth adding .history to the .gitignore as well

@dedanade
Copy link
Contributor Author

could you remove the .history files from the PR? I believe that is generated by VS Code right? it may also be worth adding .history to the .gitignore as well

Hi @emyarod, Thanks for the heads up. This has been fixed.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@alisonjoseph alisonjoseph requested review from a team and alina-jacob and removed request for a team October 30, 2024 17:20
@alisonjoseph
Copy link
Member

Want to double check with @carbon-design-system/design that this is intended for the inactive state and that the animate out wasn't done on purpose. I also want to check on if we should keep the space for the loading icon we had before.
Before PR
Screenshot 2024-10-30 at 12 25 17 PM

After changes
Screenshot 2024-10-30 at 12 24 32 PM

@tay1orjones tay1orjones removed their request for review November 15, 2024 19:47
@thyhmdo
Copy link
Member

thyhmdo commented Nov 20, 2024

Want to double check with @carbon-design-system/design that this is intended for the inactive state and that the animate out wasn't done on purpose. I also want to check on if we should keep the space for the loading icon we had before. Before PR Screenshot 2024-10-30 at 12 25 17 PM

After changes Screenshot 2024-10-30 at 12 24 32 PM

I think the inactive state should not be available at all. It will take some research to validate, but for the quick fix, I'd say that we can lose the space for the inactive state

Copy link
Member

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the above discussion, removing the loading animation and the space for in-active state makes sense, so good to go! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: InlineLoading shows animation on inactive state
5 participants