fix: avoid manual blur in Dropdown, MultiSelect to allow keyboard navigation in Firefox
#2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
fix-custom-select-blur
branch
from
12a9d11 to
0130397
Compare
|
Released in v0.87.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2083
There's a bug in Firefox where the focus is trapped inside the Dropdown button and MultiSelect field. I was able to repro with the latest FF version 134.0.1 (64-bit).
From my research, the symptoms seem similar to this bug report (although the report itself is over a decade old, and has reportedly been fixed).
This removes the unnecessary manual
blurin the "Tab" events. I've also tested Chrome, Safari, and the behavior is consistent.