Skip to content

Commit

Permalink
test(overflow-menu): add unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
metonym committed Jan 30, 2025
1 parent 88f4304 commit 306e099
Show file tree
Hide file tree
Showing 4 changed files with 120 additions and 81 deletions.
6 changes: 6 additions & 0 deletions tests/App.test.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import RecursiveList from "./RecursiveList/RecursiveList.test.svelte";
import RecursiveListHierarchy from "./RecursiveList/RecursiveList.hierarchy.test.svelte";
import Tag from "./Tag/Tag.test.svelte";
import OverflowMenu from "./OverflowMenu/OverflowMenu.test.svelte";
import { onMount } from "svelte";
const routes = [
Expand Down Expand Up @@ -63,6 +64,11 @@
name: "Tag",
component: Tag,
},
{
path: "/overflow-menu",
name: "OverflowMenu",
component: OverflowMenu,
},
] as const;
let currentPath = window.location.pathname;
Expand Down
81 changes: 0 additions & 81 deletions tests/OverflowMenu.test.svelte

This file was deleted.

30 changes: 30 additions & 0 deletions tests/OverflowMenu/OverflowMenu.test.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<script lang="ts">
import { OverflowMenu, OverflowMenuItem } from "carbon-components-svelte";
</script>

<OverflowMenu
on:close={(e) => {
console.log("close", e.detail); // { index: number; text: string; }
}}
>
<OverflowMenuItem
text="Manage credentials"
on:click={() => {
console.log("click", "Manage credentials");
}}
/>
<OverflowMenuItem
href="https://cloud.ibm.com/docs/api-gateway/"
text="API documentation"
on:click={() => {
console.log("click", "API documentation");
}}
/>
<OverflowMenuItem
danger
text="Delete service"
on:click={() => {
console.log("click", "Delete service");
}}
/>
</OverflowMenu>
84 changes: 84 additions & 0 deletions tests/OverflowMenu/OverflowMenu.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
import { render, screen } from "@testing-library/svelte";
import { user } from "../setup-tests";
import OverflowMenu from "./OverflowMenu.test.svelte";

describe("OverflowMenu", () => {
it("renders and functions correctly", async () => {
render(OverflowMenu);

const menuButton = screen.getByRole("button");
expect(menuButton).toHaveAttribute("aria-haspopup", "true");
expect(menuButton).toHaveAttribute("aria-expanded", "false");

await user.click(menuButton);
expect(menuButton).toHaveAttribute("aria-expanded", "true");

const menuItems = screen.getAllByRole("menuitem");
expect(menuItems).toHaveLength(3);
expect(menuItems[0]).toHaveFocus();

expect(menuItems[0]).toHaveTextContent("Manage credentials");
expect(menuItems[1]).toHaveTextContent("API documentation");
expect(menuItems[2]).toHaveTextContent("Delete service");

expect(menuItems[1]).toHaveAttribute(
"href",
"https://cloud.ibm.com/docs/api-gateway/",
);

expect(menuItems[2].parentElement).toHaveClass(
"bx--overflow-menu-options__option--danger",
);

const spy = vi.spyOn(console, "log");
await user.click(menuItems[0]);
expect(spy).toHaveBeenCalledWith("click", "Manage credentials");

expect(menuButton).toHaveAttribute("aria-expanded", "false");
expect(spy).toHaveBeenCalledWith("close", {
index: 0,
text: "Manage credentials",
});
});

it("handles keyboard navigation", async () => {
render(OverflowMenu);

const spy = vi.spyOn(console, "log");

const menuButton = screen.getByRole("button");
await user.click(menuButton);
expect(menuButton).toHaveAttribute("aria-expanded", "true");

let menuItems = screen.getAllByRole("menuitem");
expect(menuItems[0]).toHaveFocus();

await user.keyboard("{ArrowDown}");
expect(menuItems[1]).toHaveFocus();

await user.keyboard("{Enter}");
expect(spy).toHaveBeenCalledWith("click", "API documentation");

await user.click(menuButton);
menuItems = screen.getAllByRole("menuitem");
expect(menuItems[0]).toHaveFocus();

await user.keyboard("{ArrowUp}");
expect(menuItems[2]).toHaveFocus();

await user.keyboard("{Escape}");
expect(menuButton).toHaveAttribute("aria-expanded", "false");
expect(spy).toHaveBeenCalledWith("close", null);
});

it("closes when clicking outside", async () => {
render(OverflowMenu);

const menuButton = screen.getByRole("button");
await user.click(menuButton);
expect(menuButton).toHaveAttribute("aria-expanded", "true");

await user.click(document.body);
expect(menuButton).toHaveAttribute("aria-expanded", "false");
});
});

0 comments on commit 306e099

Please sign in to comment.