returns 400 on validator-faucets api when no validator_ids are sent#6131
Open
JYC11 wants to merge 2 commits into
Open
returns 400 on validator-faucets api when no validator_ids are sent#6131JYC11 wants to merge 2 commits into
JYC11 wants to merge 2 commits into
Conversation
JYC11
changed the title
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
JYC11
force-pushed
the
jaeyoon/fix-scan-validator-faucets-empty-output
branch
from
0d14bb2 to
c2d6a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1964
The SQL syntax crash does not seem to occur as an empty array produces
= ANY ('{}')which is valid SQL. A test asserting store returnsSeq.emptyfor an empty input was added as a regression test in caseinClausesemantics change.This PR instead addresses the user-facing concern: calling
/v0/validators/validator-faucetswith novalidator_ids(or a misspelled key likevalidator=) used to return 200 + empty list, masking the typo. It now returns HTTP 400 with a clear error.