fix loopback routes when deploying with GKE L7 ALB#6095
Open
stephencompall-DA wants to merge 10 commits into
Open
fix loopback routes when deploying with GKE L7 ALB#6095stephencompall-DA wants to merge 10 commits into
stephencompall-DA wants to merge 10 commits into
Conversation
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
This reverts commit 75839bc. Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
…loopback-with-gke-gateway [skip ci]
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Comment on lines
+1
to
+7
| !include($SPLICE_ROOT/cluster/configs/shared/scratchnet.yaml) | ||
| infra: | ||
| gkeGateway: | ||
| proxyForIstioHttp: true | ||
| cloudArmor: | ||
| enabled: true | ||
| allRulesPreviewOnly: true |
Contributor
Author
There was a problem hiding this comment.
Note checklist in PR description.
stephencompall-DA
requested review from
mblaze-da,
nicu-da and
ray-roestenburg-da
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
…loopback-with-gke-gateway [static]
This reverts commit 2bee6ca.
Assisted-by: Copilot:gpt-5.3-codex Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least participant->sequencer loopback connection needs special HTTPS handling when enabling
gkeGateway.proxyForIstioHttp; possibly other loopback connections.This adds port 80 VirtualServices as follows (note that VirtualService ports have nothing to do with http/https, they must match the gateway to take effect, and 80 is an istio redirect with GKE gateway off):
sv.*/api/sv/sv-web-ui.*scan.*/api/scan/, /registry/scan-web-ui.*wallet.*/api/validator/wallet-web-ui.*ans.*/api/validator/ans-web-ui.*splitwell.*/api/json-api/ (to participant)splitwell.*splitwell-web-ui.*docs.*(This is a bit aggressive, and I wouldn't say no to backing off a bit and breaking loopback support for some of these and seeing if things still work. But all of these are needed to match the prior behavior.)
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines