fix sv network banner to always show#6087
Open
JYC11 wants to merge 2 commits into
Open
Conversation
JYC11
force-pushed
the
jaeyoon/fix-sv-network-banner-always-show
branch
from
1247c2a to
4c6b159
Compare
JYC11
force-pushed
the
jaeyoon/fix-sv-network-banner-always-show
branch
from
4c6b159 to
fdc9384
Compare
Signed-off-by: Jaeyoon Cho <jaeyoon.cho@obsidian.systems> Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
JYC11
force-pushed
the
jaeyoon/fix-sv-network-banner-always-show
branch
from
fdc9384 to
987b1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #534
useNetworkInstanceNameattempts to get the network name from the configs (useSvConfig) first and if it fails to do so, it will get it fromuseDsoInfo. It will always return a network name (falls back to "Unknown Network").The banner in the
Layoutcomponent has been changed to always show. For networks outside of the known networks, it will default to this color:colors.neutral.30screenshot:
