Open
Conversation
The Orders server handler was changed to use ordersParams/GetOrdersPaginated returning a Page object, but Client.Orders() still sent heightAndIdRequest and expected OrderBooks (a JSON array). This caused chain 2 to fail certificate validation on every block, halting at height 1313702. - Register SellOrders as a pageable type for "orders" pages - Update Client.Orders() to send ordersRequest with committee field and parse the Page response back into OrderBooks
andrewnguyen22
requested changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the DEX batch processing pipeline to achieve same-block finality. By enabling "Fast-Track" execution of remote root DEX batches and ensuring strict
StateRootconsistency across the network, for nested chains, DEX transactions are now processed in the same block they are received.Related Issues
Closes: #N/A
Changes Made
1. Same-Block DEX Finality ("Fast-Track")
CheckMempool. The proposer now fetches the remote batch before block simulation, allowing the result to be included in the current block'sStateMachinecache.results.RootDexBatchin the block proposal. This ensures all validators receive the same batch as the proposer, preventingStateRootdivergence.FSM.Copy()to preserve therootDexBatchcache.2. Deterministic & Idempotent Processing
- Monotonic Pointer: Replaced the previous "Processed Set" logic with a single LastProcessedRootDexHeight pointer in the FSM state. This ensures a batch is never executed more than once (e.g., once via Fast-Track and once via standard sync).Behavior removedi3. Field Mapping & Logic Corrections
RootDexBatch(mirrored sync data from the root). This resolves the 1-block delay where the root chain was previously ignoring nested chain orders.4. Synchronization Robustness
Checklist
issue-#DEX-Latency.