Conversation
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
farshidtz
left a comment
There was a problem hiding this comment.
The content looks good. Thanks.
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
To save space and be more concise Co-authored-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com> Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
e6b673c to
b802a53
Compare
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
I can't tell if it's possible to use headers within the `tab-item`, as it yields a build warning and doesn't render the text. Instead, just bold the text, which may be sufficient for now. Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
1901d31 to
3dbcd32
Compare
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
todo squash this Co-authored-by: AnneCYH <anne.chew@canonical.com> Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
88a5892 to
ef49858
Compare
installed on your system Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
Co-authored-by: AnneCYH <anne.chew@canonical.com> Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
f2e5888 to
ac38f8a
Compare
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
AnneCYH
left a comment
There was a problem hiding this comment.
Hey @benjamin051000 , apologies i kept thinking this was done.
Just one final change but e'thing else looks good.
Thanks!
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
Co-authored-by: AnneCYH <anne.chew@canonical.com> Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
Co-authored-by: AnneCYH <anne.chew@canonical.com> Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
65a7615 to
c61f216
Compare
Signed-off-by: Benjamin Wheeler <benjamin.wheeler@canonical.com>
AnneCYH
left a comment
There was a problem hiding this comment.
Thanks for your effort @benjamin051000 !
farshidtz
left a comment
There was a problem hiding this comment.
Thanks for the guide.
I have a few minor suggestions which you may want to consider.
| Use the following command to add ``deb-src`` to the :file:`ubuntu-realtime-kernel.sources` file: | ||
|
|
||
| .. code-block:: shell | ||
|
|
||
| sudo sed -i '2s/^Types: deb$/Types: deb deb-src/' /etc/apt/sources.list.d/ubuntu-realtime-kernel.sources |
There was a problem hiding this comment.
Why using sed to add the deb-src but not for uncommenting that line for 22.04?
I suggest not using sed at all and simply telling what needs be added with an example. This makes it easier to understand what is being done and to revert it.
Co-authored-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
resolves #48