-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(storybook): Theming support for stories #1151
Conversation
mcslayer is not a collaborator of the repo |
This is awesome addition @mcslayer! We have a requirement for all PRs to be up to date with main branch, so please rebase now that your Vanilla update is merged, thx! |
Is there some kind of storybook documentation or recommendation that you followed when adding the theme switcher? |
There is no ready-made special documentation for this. The code is based on personal experience of using storybook in projects. |
Also, instead of "Theme" we can write the name of the active theme and It looks even better. So I can add it if you approve. |
Nice! If possible, I think it would be better for it to say both (sorry, I updated you comment by mistake instead of replying 🤦 ) |
I made the order in the commits and made 1 commit with a force push. Regarding the title: everything is primitive there. You can use the abstract "Theme", or take the title from the options. So I changed the titles everywhere in the list to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, thank you!
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Percy steps
Fixes
Fixes: # .