feat: [WD-34915] Make Admin groups immutable

[Kxiru]

Done

• Make admin groups immutable
• Disable deletion of admins row, with explanatory hover text.
• Disable selection of new permissions
• Split Group + Edit Identity API calls so that you can still edit the admins inside the admins group. I do not think this applies anymore

Note, my admin group is called "admins". Confirm whether this is the default group name or if I have a custom one.

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @Kxiru or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Navigate to Permissions > Groups
   • Observe that the above checkbox interactions behave as expected.

Screenshots

Fixes canonical/lxd#17986

[webteam-app]

Demo

Jenkins

demos.haus

[kimanhou]

Could you please include the QA steps in the description ?

Maybe we should also disable the name input and the description input in the edit side panel, instead of letting the user modify the name then receiving an error:

I also don't like being able to click on Edit permissions and then not being able to do anything. Maybe we should disable the button from the side panel and displaying what the permissions are underneath. Or change the label of the button to See permissions and completely remove the Add permissions section (and even the search bar ?)

[omarelkashef]

Should we also disable the edit button or the side panel input fields instead of having the user run into these errors?

[Kxiru]

Should we also disable the edit button or the side panel input fields instead of having the user run into these errors?

@omarelkashef Yes, thank you for bringing this up

[Kxiru]

@kimanhou I think the Permissions button should stay but can be renamed to See Permissions. Pushing a new commit that addresses all changes and changes "Edit permissions" to "View permissions".

[edlerd]

Let's still allow changing memberships in the admins group via the group form. There shouldn't be an error below, but the change should go through by skipping the admin group update and directly altering the group members:

[kimanhou]

It might not be related to this PR, but in the "Add permissions" section in the edit side panel, even if the dropdown lists are disabled, the cursor is still pointer. It would be better to have a cursor not-allowed.

Tests fail.

Same remark as David: when you modify the identities, an error is thrown while it shouldn't.

[kimanhou]

Related bug github issue on LXD repo: canonical/lxd#17986

[Kxiru]

Same remark as David: when you modify the identities, an error is thrown while it shouldn't.
Thanks for flagging, I couldn't reproduce this until I realised I was using 5.21. Working on this now.