Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Revert "Use Jammy for all builds" #26

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Conversation

MonicaisHer
Copy link
Contributor

No description provided.

@MonicaisHer MonicaisHer changed the title Default build ubuntu20.04 Revert "Use Jammy for all builds" Jul 13, 2022
@MonicaisHer MonicaisHer requested a review from farshidtz July 13, 2022 09:11
@farshidtz
Copy link
Member

farshidtz commented Jul 13, 2022

I just remembered why I set Jammy for all: device-gpio call wasn't getting the series value from the matrix and not falling back to the action's default either. This is because an empty string is passed to the action and default isn't used; see actions/runner#924 (comment).

Build log: https://github.com/canonical/edgex-nightly-build/runs/7295965153?check_suite_focus=true#step:2:75

@MonicaisHer
Copy link
Contributor Author

MonicaisHer commented Jul 13, 2022

I just remembered why I set Jammy for all. Because device-gpio call wasn't getting the series value from the matrix: https://github.com/canonical/edgex-nightly-build/runs/7295965153?check_suite_focus=true#step:2:75

could we add ubuntu_series: focal for device-gpio?

- snap: edgex-device-gpio
  arch: armhf
  ubuntu_series: focal

@farshidtz
Copy link
Member

I just remembered why I set Jammy for all. Because device-gpio call wasn't getting the series value from the matrix: https://github.com/canonical/edgex-nightly-build/runs/7295965153?check_suite_focus=true#step:2:75

could we add ubuntu_series: focal for device-gpio?

- snap: edgex-device-gpio
  arch: armhf
  ubuntu_series: focal

Ya that should solve it. Or we change the action to default to focal when the input is empty. We can then remove some complexity here.

@MonicaisHer
Copy link
Contributor Author

I just remembered why I set Jammy for all. Because device-gpio call wasn't getting the series value from the matrix: https://github.com/canonical/edgex-nightly-build/runs/7295965153?check_suite_focus=true#step:2:75

could we add ubuntu_series: focal for device-gpio?

- snap: edgex-device-gpio
  arch: armhf
  ubuntu_series: focal

Ya that should solve it. Or we change the action to default to focal when the input is empty. We can then remove some complexity here.

The default is focal already:
https://github.com/canonical/edgex-launchpad-build-action/blob/16e23cf21ddc03680412eb3b9ed6de946e23a2ac/action.yml#L19-L22

@farshidtz
Copy link
Member

The default is focal already: https://github.com/canonical/edgex-launchpad-build-action/blob/16e23cf21ddc03680412eb3b9ed6de946e23a2ac/action.yml#L19-L22

I've updated my comment and explained why that doesn't work: #26 (comment)

@farshidtz farshidtz merged commit 638666c into main Jul 13, 2022
@farshidtz farshidtz deleted the default-build-ubuntu20.04 branch July 13, 2022 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants