Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes compatibility with older versions of netcat-openbsd on UC16 devices by replacing the -N flag (not supported in version 1.105-7ubuntu1) with -q 1, which has equivalent behavior and is supported in both old and new versions.
Changes:
- Updated the
nccommand inSnapdAPIClient.get()to use-q 1instead of-N - Updated the corresponding test assertion to match the new command
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cert-tools/toolbox/src/toolbox/interfaces/snapd.py | Changed netcat flags from -N to -q 1 for UC16 compatibility |
| cert-tools/toolbox/tests/interfaces/test_snapd.py | Updated test assertion to verify the new netcat command structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fernando79513
approved these changes
Feb 18, 2026
Contributor
fernando79513
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UC16 has an ancient
netcat-openbsdversion:OpenBSD netcat (Debian patchlevel 1.105-7ubuntu1)This version does not support
-Nflag:This PR introduces compliance with older versions of
netcat-openbsd.How to test
To reproduce run
nc -Non the UC16 device.Documentation
https://manpages.debian.org/bookworm/netcat-openbsd/nc.1.en.html