Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest ad-hoc subprocess with new context pad #4836

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Feb 14, 2025

Proposed Changes

deps: update to @camunda/improved-canvas

fix: suggest ad-hoc subprocess with new context pad

Closes #4813

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 14, 2025
@barmac barmac requested review from a team, jarekdanielak and misiekhardcore and removed request for a team February 14, 2025 16:29
@jarekdanielak jarekdanielak removed the request for review from misiekhardcore February 14, 2025 17:25
@nikku
Copy link
Member

nikku commented Feb 17, 2025

@barmac This needs rebase it looks like, but otherwise 👍

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts, cf. #4836 (comment)

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Feb 17, 2025
fix: suggest ad-hoc subprocess with new context pad

Closes #4813
@jarekdanielak jarekdanielak force-pushed the 4813-add-ad-hoc-to-append branch from bd9336c to 410d48d Compare February 17, 2025 13:01
@jarekdanielak
Copy link
Contributor

Rebased. Will merge when the CI goes green.

@jarekdanielak jarekdanielak merged commit 2a828cf into develop Feb 17, 2025
10 of 11 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Feb 17, 2025
@jarekdanielak jarekdanielak deleted the 4813-add-ad-hoc-to-append branch February 17, 2025 13:12
@github-actions github-actions bot added this to the M86 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ad-hoc sub process not visible from create/Append menu
3 participants