-
Notifications
You must be signed in to change notification settings - Fork 216
SAP improvements #5902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP improvements #5902
Conversation
👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.7/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
docs/components/connectors/react-components/_connectors-table.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christinaausley I've reviewed this, it LGTM!
Sorry @camundom -- had to resolve a merge conflict 👍 |
@mesellings Can I please get a hand wavy approval on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hand wavy approval for you 😊 👍
just wanted to drop an appreciation 🪙 for you @christinaausley and @mesellings for plowing through the SAP docs and improving it significantly. Thanks! 🙇 |
All kudos goes to @christinaausley for this work - I did nothing! Always grateful to hear feedback on docs work - appreciate it 🚀 |
Description
Closes #5874. A handful of miscellaneous SAP improvements.
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.