Skip to content

Conversation

christinaausley
Copy link
Contributor

@christinaausley christinaausley commented May 30, 2025

Description

Closes #5874. A handful of miscellaneous SAP improvements.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the Documentation team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and are in the /docs directory (version 8.8).
  • My changes are for an already released minor and are in a /versioned_docs directory.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.7/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.7/components/camunda-integrations/sap/img/sap-btp-plugin-model-user-task.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley marked this pull request as ready for review June 6, 2025 18:56
@camunda-docs-pr-automation camunda-docs-pr-automation bot moved this to 👀 In Review in Documentation Team Jun 6, 2025
@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Jun 6, 2025
camundom
camundom previously approved these changes Jun 10, 2025
Copy link
Contributor

@camundom camundom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @christinaausley I've reviewed this, it LGTM!

@christinaausley
Copy link
Contributor Author

Sorry @camundom -- had to resolve a merge conflict 👍

@christinaausley christinaausley requested a review from camundom June 10, 2025 21:45
@christinaausley
Copy link
Contributor Author

@mesellings Can I please get a hand wavy approval on this PR?

Copy link
Collaborator

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hand wavy approval for you 😊 👍

@christinaausley christinaausley merged commit 60df804 into main Jun 11, 2025
9 checks passed
@christinaausley christinaausley deleted the sap-improvements branch June 11, 2025 08:00
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Documentation Team Jun 11, 2025
@vobu
Copy link
Contributor

vobu commented Jun 11, 2025

just wanted to drop an appreciation 🪙 for you @christinaausley and @mesellings for plowing through the SAP docs and improving it significantly. Thanks! 🙇

@mesellings
Copy link
Collaborator

just wanted to drop an appreciation 🪙 for you @christinaausley and @mesellings for plowing through the SAP docs and improving it significantly. Thanks! 🙇

All kudos goes to @christinaausley for this work - I did nothing! Always grateful to hear feedback on docs work - appreciate it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Address feedback for SAP documentation
4 participants