Skip to content

update the yaml file to fix the problem of incompatibility with Commonalities-0.9.0 in pr39 - #40

Merged
SentianSun merged 1 commit into
camaraproject:mainfrom
ChinaUnicomXiaoDongrui:main
Sep 30, 2026
Merged

SentianSun merged 1 commit into
camaraproject:mainfrom
ChinaUnicomXiaoDongrui:main

Conversation

@ChinaUnicomXiaoDongrui

@ChinaUnicomXiaoDongrui ChinaUnicomXiaoDongrui commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Bug fix

What this PR does / why we need it:

This PR updates the YAML configuration to fix the problem of adaptive Commonalities-0.9.0
The main changes are:

  • Solve the problems involved in "The hint" P-027 (line 56)
  • The info.x-camara-commonalities have been updated from 0.8.0-rc.2 to 0.9.0 (line 69)
  • The sink/sinkCredential property has been updated to better comply with the Commonalities specification (line 483, line 564)
  • Four callbacks' keys have been modified (line131, line 243, line 317, line 390)
  • The error response references for five operations have been modified
  • Modify securitySchemes to public $ref

Which issue(s) this PR fixes:

Make it compatible with CAMARA Commonalities 0.9.0 mentioned by @hdamker in pr 39

@ChinaUnicomXiaoDongrui

ChinaUnicomXiaoDongrui commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

@hdamker Thanks for the review and for the pointer to the Commonalities 0.9.0 analysis page, we have resolved this hint [P-027] and made individual modifications based on the contents of the Commonalities+0.9.0 update. The modified contents are:

  1. Solve the problems involved in "The hint" [P-027](line 56)
  2. The info.x-camara-commonalities have been updated from 0.8.0-rc.2 to 0.9.0(line 69)
  3. The sink/sinkCredential property has been updated to better comply with the Commonalities specification(line483, line564)
  4. Four callbacks' keys have been modified(line131, line243, line317, line390)
  5. The error response references for five operations have been modified
  6. Modify securitySchemes to public $ref(line419–778)

@ChinaUnicomXiaoDongrui

Copy link
Copy Markdown
Contributor Author

@hdamker For now, we won't merge this pr. If you have any further questions, please feel free to raise them and we will update as required. Thank you. If you need to merge this pr, please let me know and I will contact another codeowner for the merge.

@hdamker

hdamker commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

@ChinaUnicomXiaoDongrui thanks for the updates here.

One process request before this moves on: could you fill in the PR description using the repository's pull request template (.github/pull_request_template.md)? The current description ("update the yaml file to solve other problems") doesn't tell reviewers — or later readers — what actually changed.

The template sections that matter most here:

  • What type of PR is this and What this PR does / why we need it — so reviewers know what to look for in a 167/258-line diff.
  • Which issue(s) this PR fixes — link the issue(s) this addresses.
  • The PR title itself — it's what typically ends up in CHANGELOG.md, and "update the yaml file to solve other problems" won't make a useful changelog entry. Please make it specific to the actual changes.

See also the CAMARA contribution guidelines: https://github.com/camaraproject/Governance/blob/main/CONTRIBUTING.md

Happy to review the content once the description is in place.

@ChinaUnicomXiaoDongrui ChinaUnicomXiaoDongrui changed the title update the yaml file to solve other problems update the yaml file to fix the issue of incompatibility with Commonalities-0.9.0 in pr39 Sep 24, 2026
@ChinaUnicomXiaoDongrui ChinaUnicomXiaoDongrui changed the title update the yaml file to fix the issue of incompatibility with Commonalities-0.9.0 in pr39 update the yaml file to fix the problem of incompatibility with Commonalities-0.9.0 in pr39 Sep 24, 2026
@ChinaUnicomXiaoDongrui

Copy link
Copy Markdown
Contributor Author

@ChinaUnicomXiaoDongrui thanks for the updates here.

One process request before this moves on: could you fill in the PR description using the repository's pull request template (.github/pull_request_template.md)? The current description ("update the yaml file to solve other problems") doesn't tell reviewers — or later readers — what actually changed.

The template sections that matter most here:

  • What type of PR is this and What this PR does / why we need it — so reviewers know what to look for in a 167/258-line diff.
  • Which issue(s) this PR fixes — link the issue(s) this addresses.
  • The PR title itself — it's what typically ends up in CHANGELOG.md, and "update the yaml file to solve other problems" won't make a useful changelog entry. Please make it specific to the actual changes.

See also the CAMARA contribution guidelines: https://github.com/camaraproject/Governance/blob/main/CONTRIBUTING.md

Happy to review the content once the description is in place.

@hdamker Thanks for the reminder. I’ve updated the PR description using the repository template, including the PR type, what changed, and the related context. I’ve also changed the title to "update the yaml file to fix the problem of incompatibility with Commonalities-0.9.0 in pr39". I'm not sure if I have described clearly what work I have done and what problems I have solved in this pr. I hope to receive your Review and reply. Thank you. If there are any other questions, I would be more than happy to discuss and solve them with you.

@hdamker

hdamker commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@ChinaUnicomXiaoDongrui thanks for updating the description.

From the Commonalities side the direction looks right: the notification part now follows the implicit-subscription pattern of the Commonalities r4.4 sample-implicit-events.yaml template (sink/sinkCredential, CloudEvent-based notification schema, EVENT_NOTIFICATIONS_NOT_SUPPORTED), the common schemas and security schemes are referenced instead of copied, and CAMARA Validation passes.

The content review of the API design itself is up to the codeowners of this repository. Please also check the open points in #30 against the current state of the API before the next release attempt.

@ChinaUnicomXiaoDongrui

Copy link
Copy Markdown
Contributor Author

@ChinaUnicomXiaoDongrui thanks for updating the description.

From the Commonalities side the direction looks right: the notification part now follows the implicit-subscription pattern of the Commonalities r4.4 sample-implicit-events.yaml template (sink/sinkCredential, CloudEvent-based notification schema, EVENT_NOTIFICATIONS_NOT_SUPPORTED), the common schemas and security schemes are referenced instead of copied, and CAMARA Validation passes.

The content review of the API design itself is up to the codeowners of this repository. Please also check the open points in #30 against the current state of the API before the next release attempt.

@hdamker Thank you very much for your review. I will contact our codeowner to Review the specific business content and then continue to promote other work related to the API release

@SentianSun SentianSun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@SentianSun
SentianSun merged commit d0ed2c0 into camaraproject:main Sep 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants