Repository navigation
update the yaml file to fix the problem of incompatibility with Commonalities-0.9.0 in pr39 - #40
Conversation
|
@hdamker Thanks for the review and for the pointer to the Commonalities 0.9.0 analysis page, we have resolved this hint [P-027] and made individual modifications based on the contents of the Commonalities+0.9.0 update. The modified contents are:
|
|
@hdamker For now, we won't merge this pr. If you have any further questions, please feel free to raise them and we will update as required. Thank you. If you need to merge this pr, please let me know and I will contact another codeowner for the merge. |
|
@ChinaUnicomXiaoDongrui thanks for the updates here. One process request before this moves on: could you fill in the PR description using the repository's pull request template ( The template sections that matter most here:
See also the CAMARA contribution guidelines: https://github.com/camaraproject/Governance/blob/main/CONTRIBUTING.md Happy to review the content once the description is in place. |
@hdamker Thanks for the reminder. I’ve updated the PR description using the repository template, including the PR type, what changed, and the related context. I’ve also changed the title to "update the yaml file to fix the problem of incompatibility with Commonalities-0.9.0 in pr39". I'm not sure if I have described clearly what work I have done and what problems I have solved in this pr. I hope to receive your Review and reply. Thank you. If there are any other questions, I would be more than happy to discuss and solve them with you. |
|
@ChinaUnicomXiaoDongrui thanks for updating the description. From the Commonalities side the direction looks right: the notification part now follows the implicit-subscription pattern of the Commonalities r4.4 The content review of the API design itself is up to the codeowners of this repository. Please also check the open points in #30 against the current state of the API before the next release attempt. |
@hdamker Thank you very much for your review. I will contact our codeowner to Review the specific business content and then continue to promote other work related to the API release |
What type of PR is this?
What this PR does / why we need it:
This PR updates the YAML configuration to fix the problem of adaptive Commonalities-0.9.0
The main changes are:
Which issue(s) this PR fixes:
Make it compatible with CAMARA Commonalities 0.9.0 mentioned by @hdamker in pr 39