Skip to content

Component may be unused #216

Description

@rartych

Problem description

code/API_definitions/webrtc-events-subscriptions.yaml:1098:29 (HTTPSubscriptionRequest) — [S-211] Potentially unused component has been detected.
code/API_definitions/webrtc-events-subscriptions.yaml:1107:30 (HTTPSubscriptionResponse) — [S-211] Potentially unused component has been detected.

Expected behavior

Add to SubscriptionRequest:

      discriminator:
        propertyName: protocol
        mapping:
          HTTP: "#/components/schemas/HTTPSubscriptionRequest"

and to Subscription::

      discriminator:
        propertyName: protocol
        mapping:
          HTTP: "#/components/schemas/HTTPSubscriptionResponse"

and update HTTPSubscriptionRequest, HTTPSubscriptionResponse to use common schema definitions.

Alternative solution
If no other protocols are not planned for event notification then schemas may be simplified (and unused components removed)

Additional context

https://github.com/camaraproject/Commonalities/blob/32b878daa2bcb253abf91c36daa5c8b88b5cb5fe/artifacts/api-templates/sample-service-subscriptions.yaml#L650-L666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions