Skip to content

Align kyc-tenure to Commonalities r4.4 - #99

Open
albertoramosmonagas wants to merge 12 commits into
camaraproject:mainfrom
albertoramosmonagas:chore/commonalities-r4.4-alignment
Open

Align kyc-tenure to Commonalities r4.4#99
albertoramosmonagas wants to merge 12 commits into
camaraproject:mainfrom
albertoramosmonagas:chore/commonalities-r4.4-alignment

Conversation

@albertoramosmonagas

@albertoramosmonagas albertoramosmonagas commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Align Tenure API to Commonalities r4.4 (v0.9.0) as part of Sync26 M3 extension release cycle.

Changes:

  • Update error response references from deprecated Generic* to new referenceable responses (BadRequest400, Unauthenticated401, PermissionDenied403, NotFound404, UnprocessableContent422)

Which issue(s) this PR fixes:

Fixes #70

Changelog input

 release-note
chore: align Tenure API to Commonalities r4.4 with updated error response references

@albertoramosmonagas

albertoramosmonagas commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Needs to modify the CAMARA_common.yaml:

[S-229] '#/components/responses/BadRequestWithRange400' does not exist @ 'code/common/CAMARA_common.yaml' | Suggestion: The $ref points to a JSON pointer that does not exist in the target file. Check the pointer name against the target's components section — a schema renamed or removed in a newer Commonalities release is the usual cause. Fix the reference in this API definition; do not edit code/common/.

@albertoramosmonagas
albertoramosmonagas force-pushed the chore/commonalities-r4.4-alignment branch from b2d6951 to 23ab6b1 Compare September 17, 2026 09:14
@albertoramosmonagas
albertoramosmonagas marked this pull request as ready for review September 17, 2026 09:26
eric-murray
eric-murray previously approved these changes Sep 17, 2026
View reviewed changes
PedroDiez
PedroDiez reviewed Sep 17, 2026
View reviewed changes

@PedroDiez PedroDiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally linter indicates a comment.

It can be checked from https://github.com/camaraproject/Tenure/blob/main/code/common/info-description-templates.yaml

To have exactly the content from the info-description template

Comment thread code/API_definitions/kyc-tenure.yaml Outdated
Comment thread code/API_definitions/kyc-tenure.yaml Outdated
@albertoramosmonagas @PedroDiez
fix(kyc-tenure.yaml): Applicable error is IdentifierNotFound404
709b91c 
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
PedroDiez
PedroDiez approved these changes Sep 17, 2026
View reviewed changes

@PedroDiez PedroDiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fernandopradocabrillo
fernandopradocabrillo previously approved these changes Sep 17, 2026
View reviewed changes

@fernandopradocabrillo fernandopradocabrillo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GillesInnov35

GillesInnov35 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@albertoramosmonagas , Commonalities r4.4 include a new 429 error TOO_MANY_REQUEST. This concerns also kyc-tenure I think.

GillesInnov35
GillesInnov35 previously approved these changes Sep 29, 2026
View reviewed changes

@GillesInnov35 GillesInnov35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @albertoramosmonagas

@albertoramosmonagas

albertoramosmonagas commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Changes applied to add 429 error @camaraproject/tenure_codeowners

fernandopradocabrillo
fernandopradocabrillo previously approved these changes Sep 29, 2026
View reviewed changes

@fernandopradocabrillo fernandopradocabrillo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PedroDiez
PedroDiez reviewed Sep 30, 2026
View reviewed changes
Comment thread code/Test_definitions/kyc-tenure.feature Outdated
Comment thread code/Test_definitions/kyc-tenure.feature
PedroDiez
PedroDiez reviewed Sep 30, 2026
View reviewed changes
Comment thread code/Test_definitions/kyc-tenure.feature Outdated
PedroDiez
PedroDiez approved these changes Oct 1, 2026
View reviewed changes

@PedroDiez PedroDiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernandopradocabrillo fernandopradocabrillo fernandopradocabrillo approved these changes
@eric-murray eric-murray eric-murray left review comments
@GillesInnov35 GillesInnov35 GillesInnov35 left review comments
@grgpapadopoulos grgpapadopoulos Awaiting requested review from grgpapadopoulos grgpapadopoulos is a code owner
+1 more reviewer
@PedroDiez PedroDiez PedroDiez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scope of KYC Tenure v0.3.0

5 participants

@albertoramosmonagas @GillesInnov35 @PedroDiez @fernandopradocabrillo @eric-murray