Skip to content

Add test coverage for PRIVATE_KEY_JWT sink credential and 422 PRIVATE_KEY_JWT_NOT_CONFIGURED - #76

Merged
albertoramosmonagas merged 1 commit into
mainfrom
fix/issue-75
Sep 24, 2026
Merged

albertoramosmonagas merged 1 commit into
mainfrom
fix/issue-75

Conversation

@albertoramosmonagas

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • tests

What this PR does / why we need it:

This PR adds the missing test coverage for PRIVATE_KEY_JWT sink credentials in the Predictive Connectivity Data API. It includes:

  • A dedicated test scenario exercising PRIVATE_KEY_JWT as a valid SinkCredential type.
  • A new 422 PRIVATE_KEY_JWT_NOT_CONFIGURED scenario, aligned with the canonical Commonalities test template.

Which issue(s) this PR fixes:

Fixes #75

Special notes for reviewers:

The issue suggested either extending the existing 400.07 scenario outline or adding a dedicated scenario for PRIVATE_KEY_JWT. This PR follows the dedicated-scenario approach because PRIVATE_KEY_JWT is a supported credential type and therefore should not be included among the invalid credential examples. This keeps the test semantics aligned with the API schema and avoids asserting an incorrect 400 response.

Changelog input

 release-note
Added test coverage for PRIVATE_KEY_JWT sink credentials, including the 422 PRIVATE_KEY_JWT_NOT_CONFIGURED error scenario.

@albertoramosmonagas
albertoramosmonagas marked this pull request as ready for review September 1, 2026 15:34
@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS (with warnings)

0 errors, 2 warnings, 3 hints | Profile: standard

View full results

@albertoramosmonagas

Copy link
Copy Markdown
Contributor Author

Hi @eric-murray, ready for review.

@albertoramosmonagas

Copy link
Copy Markdown
Contributor Author

Hi @eric-murray, I plan to prepare the new release plan and the commonalities changes, any problem to merge this PR?

@albertoramosmonagas
albertoramosmonagas merged commit c3670f4 into main Sep 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test coverage for PRIVATE_KEY_JWT sink credential and 422 PRIVATE_KEY_JWT_NOT_CONFIGURED

2 participants