Conversation
|
Hi @vlasatno, thanks for the PR. To follow CAMARA's standard procedures, you must first create an issue and link it to this PR. Also, the group's next meeting is on June 9. Please let us know if you can attend to discuss the proposal. |
Hello @albertoramosmonagas, we found the information to just create a pull request here. Perhaps this information can be updated to reflect the workflow you propose here. I will add and link an issue post-hoc now. |
|
Hi, I understand that this might not be entirely clear. The details regarding the issue are discussed right below. If you think it could be improved, you can create an issue in the Governance group for that purpose. No problem, we’ll discuss this issue in the group and also offline. Thank you very much. |
| enum: | ||
| - C2 | ||
| - STREAM_4K | ||
| - TELE_OPERATION |
There was a problem hiding this comment.
As discussed in camaraproject/PredictiveConnectivityData#53, please add at least one request example using TELE_OPERATION in the examples section of the retrieveConnectivity operation (alongside the existing C2 examples). This improves the spec as documentation and makes the new service level immediately testable.
There was a problem hiding this comment.
Can you clarify what exactly the purpose would be of this example. I also was unable to understand from the issue.
I added something just now, but I am not sure it is what you mean as it seems quite redundant to me.
There was a problem hiding this comment.
Thanks @vlasatno, the example is exactly what was requested. OpenAPI examples serve as inline documentation (rendered by Swagger UI, Redocly, etc.) and as the basis for contract tests and Gherkin feature files. Yours also adds networkType and precision, which the existing C2 examples omit, so it is complementary rather than redundant.
Separately, there is a YAML indentation issue introduced in the latest commits: type: string under ServiceLevel is indented with 2 spaces instead of 6. It needs to be at the same level as description: and enum: to remain a property of ServiceLevel. As it stands, this will break OpenAPI parsing.
albertoramosmonagas
left a comment
There was a problem hiding this comment.
Thanks for the update, @vlasatno. The ServiceLevel description improvements and the TELE_OPERATION definition are mostly aligned with what was agreed in #53.
Two items need attention before this can be merged:
- The UNSUPPORTED_SERVICE_LEVEL paragraph was removed from the ServiceLevel description (see inline comment) — this looks like a merge oversight and should be restored.
- At least one request example for TELE_OPERATION should be added, as agreed in the issue discussion.
Regarding timing: we are currently finalising the sync26 meta-release. This PR will remain in the backlog until that work is complete. Once the meta-release is wrapped up, we can pick this up in the next cycle.
What type of PR is this?
Add one of the following kinds:
Fixes #53
What this PR does / why we need it:
TNO, within the European funded ENVELOPE project, is using the predictive connectivity data API to facilitate a tele-operated use case, with automotive industry partners. To this end, we have added a new value to the
ServiceLevelenum in our deployment. We think it would be a good addition to the API.