Skip to content

docs: update inline API documentation, rename schemas and align terminology - #153

Open
albertoramosmonagas wants to merge 9 commits into
camaraproject:mainfrom
albertoramosmonagas:issue/152
Open

albertoramosmonagas wants to merge 9 commits into
camaraproject:mainfrom
albertoramosmonagas:issue/152

Conversation

@albertoramosmonagas

@albertoramosmonagas albertoramosmonagas commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Updates the info.description field with expanded terminology and clarified definitions per release management review. Renames schemas (Area->GeoArea, AreaType->GeoAreaType, Polygon->GeoPolygon, ResponseStatus->ResponseQualityInfo) to avoid collision with CAMARA common datatypes. Removes all people/km2 references, deduplicates repeated sections, fixes non-ASCII characters, and aligns terminology (API Consumer, OperationId vs x-correlator).

Which issue(s) this PR fixes:

Fixes #152, #154

Special notes for reviewers:

Population Density is now defined as "Estimated number of people in a grid cell during a one-hour time slot, expressed as an integer value." All people/km2 references have been removed from the file, including schema field descriptions (pplDensity, maxPplDensity, minPplDensity) and the DensityEstimation schema description.

The ResponseQualityInfo rename aligns with the equivalent change proposed in Predictive Connectivity Data (issue camaraproject/PredictiveConnectivityData#86). ResponseQualityInfo was preferred over DataQualityInfo because the response can include non-data values such as OPERATION_NOT_COMPLETED.

Changelog input

 release-note
Updated info.description with expanded terminology definitions, reorganized API documentation structure, renamed Area/AreaType/Polygon to GeoArea/GeoAreaType/GeoPolygon, renamed ResponseStatus to ResponseQualityInfo, and aligned all field descriptions for consistency.

@albertoramosmonagas

Copy link
Copy Markdown
Contributor Author

Hi @tanjadegroot, some changes applied to the current txt.

  1. Density. The Introduction and the definition of Population Density no longer refer to “per square kilometer.” It is now defined as the estimated number of people per cell and per hour, consistently with the pplDensity fields.

  2. Polygon grid (in Grid Cell and Precision → POLYGON). It now refers to the geohash cells covering the polygon, rather than converting the polygon vertices into geohashes. Level 7 is now shown only as the default value, and indicative cell sizes have been added.

  3. Geohash.

    • Replaced third-party website references with a Wikipedia link.
    • Level 12 is now described as the “maximum supported by this API.”
    • Corrected the Spain example to use "e".
  4. Polygon outside the supported area. The response is now status: AREA_NOT_SUPPORTED instead of an “empty array.”

  5. Geohash list.

    • Restored the requirement that POLYGON must be supported by all MNOs.
    • Restored the UNSUPPORTED_AREA_TYPE error.
  6. 422 errors. Added the complete error codes, including the POPULATION_DENSITY_DATA. prefix.

  7. PRIVATE_KEY_JWT. Restored the original wording (“would be repeated”), which no longer contradicts the previous sentence.

  8. Callback. Replaced “should” with “RECOMMENDED,” consistently with the other section describing callback behavior.

  9. Restored links. Re-added the references to k-anonymity and Identity and Consent Management in the authentication section.

jgarciahospital
jgarciahospital previously approved these changes Oct 1, 2026

@jgarciahospital jgarciahospital left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanjadegroot tanjadegroot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertoramosmonagas Many thanks for the update !! I included a few comments.

Comment thread code/API_definitions/population-density-data.yaml Outdated
Comment thread code/API_definitions/population-density-data.yaml Outdated
Comment thread code/API_definitions/population-density-data.yaml Outdated
Comment thread code/API_definitions/population-density-data.yaml Outdated
Comment thread code/API_definitions/population-density-data.yaml
Comment thread code/API_definitions/population-density-data.yaml Outdated
Comment thread code/API_definitions/population-density-data.yaml Outdated
Comment thread code/API_definitions/population-density-data.yaml Outdated
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
@albertoramosmonagas albertoramosmonagas changed the title docs: update info.description with expanded terminology and clarifications docs: update inline API documentation, rename schemas and align terminology Oct 6, 2026
@albertoramosmonagas

Copy link
Copy Markdown
Contributor Author

Hi @tanjadegroot, I think everything from the release management review has already been implemented.

@tanjadegroot tanjadegroot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! Thanks @albertoramosmonagas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-line API documentation updates

3 participants