Skip to content

fix(openapi): Fix #107 - Class Names are in SNAKE_CASE but should be … - #108

Merged
jgarciahospital merged 5 commits into
camaraproject:mainfrom
patrice-conil:patrice_conil/fix-issue-107
Feb 18, 2026
Merged

jgarciahospital merged 5 commits into
camaraproject:mainfrom
patrice-conil:patrice_conil/fix-issue-107

Conversation

@patrice-conil

Copy link
Copy Markdown
Contributor

Some Class Names are in SNAKE_CASE but should be in CamelCase

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction

What this PR does / why we need it:

This PR fixes issue #107 by renaming classes and of course increments spec version

Which issue(s) this PR fixes:

Fixes #107

Special notes for reviewers:

Only changes NO_DATA, LOW_DENSITY and DENSITY_ESTIMATION class names

Changelog input

 release-note

NO_DATA => NoData
LOW_DENSITY => LowDensity
DENSITY_ESTIMATION => DensityEstimation



Comment thread code/API_definitions/population-density-data.yaml Outdated
@jgarciahospital

Copy link
Copy Markdown
Collaborator

pending to review API version (and path) and AP testplan modifications

Co-authored-by: Jorge Garcia Hospital <129095857+jgarciahospital@users.noreply.github.com>
@patrice-conil

Copy link
Copy Markdown
Contributor Author

pending to review API version (and path) and AP testplan modifications

Hi @jgarciahospital,
I think there is no impact on the test plan as it only refers to the discriminator values ​​which remain unchanged.

@bigludo7

bigludo7 commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

Hello @jgarciahospital @sachinvodafone @maheshc01
Kind reminder for this one - Any blocking for merging this one?
Thanks

CampusOxide
CampusOxide previously approved these changes Nov 3, 2025
sachinvodafone
sachinvodafone previously approved these changes Nov 3, 2025
@sachinvodafone

Copy link
Copy Markdown
Collaborator

Please ignore my another github user (@CampusOxide) approval on this

@patrice-conil

Copy link
Copy Markdown
Contributor Author

Hello, path updated to /vwip as requested by @jgarciahospital

@sachinvodafone
sachinvodafone dismissed CampusOxide’s stale review November 10, 2025 10:09

This is another account of Sachin' so please ignore this request.

@albertoramosmonagas albertoramosmonagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgarciahospital jgarciahospital left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgarciahospital
jgarciahospital merged commit d624a4f into camaraproject:main Feb 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some model names use SNAKE_CASE in place of CamelCase

6 participants