Repository navigation
fix: reference DateTime schema for accessDate - #104
Merged
Merged
Conversation
heliu0
previously approved these changes
Sep 18, 2026
Contributor
|
@cnzj-Gc have you defined an own PR description template for the repository or just forgot to tell your agent to use the template available within the repo? Does not mean that information isn't complete or helpful ... it is just difficult to read PR descriptions across the project if they are all differ in structure. |
Contributor
|
Beyond that I'm not a codeowner here, so no need for my review. |
hdamker
removed their request for review
September 18, 2026 08:39
hdamker
reviewed
Sep 18, 2026
|
|
||
| version: wip | ||
| x-camara-commonalities: "0.7" | ||
| x-camara-commonalities: "0.8.0" |
Contributor
There was a problem hiding this comment.
Suggested change
| x-camara-commonalities: "0.8.0" | |
| x-camara-commonalities: "0.9.0" |
as your referring to r4.4 now.
Contributor
Author
|
@hdamker Thanks for the suggestion — I've updated the PR description to follow the repository's PR template, and also corrected x-camara-commonalities to "0.9.0" (Commonalities r4.4). |
heliu0
approved these changes
Sep 18, 2026
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Closes #90.
accessDateinTrafficAnalysisResponse.records.itemsnow references the CAMARA commonDateTimeschema instead of a locally definedtype: stringwithformat: date.The
accessDatefield represents the statistical point of each record, whose granularity depends on the requestedfrequency:frequency=DAY: the date of the day (00:00:00Z)frequency=HOUR: the start of the hour (HH:00:00Z)The previous local definition (
type: string,format: date) could only expressYYYY-MM-DD, which cannot represent the hour-level statistical point required byfrequency=HOUR. It also lacked proper RFC 3339 / timezone compliance.Using the shared
DateTimeschema:DAYandHOURgranularitiesstartDateandendDateChanges made:
accessDatenow referencesDateTimeaccessDateexample updated from"2024-06-07"to"2024-06-07T00:00:00Z"TrafficAnalysisSuccessexample updated accordinglyx-camara-commonalitiesupdated to"0.9.0"(Commonalities r4.4)Which issue(s) this PR fixes:
Fixes #90
Special notes for reviewers:
We deliberately did not use the
Dateschema here (as originally suggested in #90) becauseDateonly expressesYYYY-MM-DDand cannot represent the hour-level statistical point required byfrequency=HOUR.DateTimeis the correct fit for the semantics of this field.No changes to
network-traffic-analysis-getTrafficAnalysis.featureare required. The existing test scenarios validate the response body against theTrafficAnalysisResponseschema rather than assertingaccessDateformat directly, so the schema change is picked up automatically.Changelog input