Repository navigation
Commonalities r4.4 alignment - #66
GillesInnov35 wants to merge 12 commits into
Conversation
Updated references to error responses in the KYC age verification API specification to point to the correct components in CAMARA_common.yaml.
CAMARA Validation — PASS0 errors, 0 warnings, 6 hints | Profile: standard |
Removed various error response definitions from the KYC age verification API specification, retaining only the 'not_available' enum value.
PedroDiez
left a comment
PedroDiez
left a comment
There was a problem hiding this comment.
LGTM for API Spec, minor coments on tests file (editorial aligment)
There was a problem hiding this comment.
Align 401 tests naming and wording with https://github.com/camaraproject/Commonalities/blob/r4.4/artifacts/testing/sample-service-template.feature
There was a problem hiding this comment.
Align 400 tests naming and wording with https://github.com/camaraproject/Commonalities/blob/r4.4/artifacts/testing/sample-service-template.feature#L175
There was a problem hiding this comment.
Minor aligment with Commonalities r4.4: https://github.com/camaraproject/Commonalities/blob/r4.4/artifacts/testing/C02-phoneNumber-errors.feature#L33
Removed redundant examples for required_property in age verification tests.
|
@PedroDiez , could review file changes in kyc-age-verification.feature. Scenarios should be now aligned on Commonalities r4.4 tests scenarios. Thanks |
| And the response property "$.message" contains a user friendly text | ||
|
|
||
| @kyc-age-verification_verifyAge_403.02_api_client_token_mismatch | ||
| Scenario: "/verify" not created by the API client given in the access token |
There was a problem hiding this comment.
NOTE: This can be for WG decision, replace /verify by verifyAge (May be done later in case commented by RM)
There was a problem hiding this comment.
thanks a lot @PedroDiez ,
verifyAge is the operationId not the resource name. In test scenario_template {resource} must be replaced by the API resource which is consumed is /verify, isn't it ?
There was a problem hiding this comment.
To me is fine, just in case that comment would happen later, it will be no problem from our side
|
@ToshiWakayama-KDDI , could you review this PR. Thanks a lot |
| And the header "Content-Type" is set to "application/json" | ||
| And the header "Authorization" is set to a valid access token | ||
| And the header "x-correlator" complies with the schema at "#/components/schemas/XCorrelator" | ||
| And the header "x-correlator" complies with the schema at "../common/CAMARA_common.yaml#/components/headers/x-correlator" |
There was a problem hiding this comment.
This update is not needed.
In the API spec, the reference points to the local CAMARA_common.yaml copy, which is to avoid to change that reference it in case it would be updated (that is the changes are sync via updates of that local copy of commonalities)
When API bundling is performed via RM automation flow, that process makes auto-contained schemas so that the current value is valid
There was a problem hiding this comment.
3 participants
Updated references to error responses in the KYC age verification API specification to point to the correct components in CAMARA_common.yaml.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Commonalities r4.4 alignment
Which issue(s) this PR fixes:
Fixes #67