Repository navigation
Conversation
…he common code set
hdamker
requested review from
bigludo7,
jlurien and
maxl2287
as code owners
September 23, 2026 19:12
hdamker
marked this pull request as draft
September 24, 2026 07:55
…here extra codes cannot occur
…PermissionDenied403 directly
Contributor
Author
hdamker
marked this pull request as ready for review
September 24, 2026 08:15
maxl2287
approved these changes
Sep 26, 2026
Contributor
Author
|
Merging so that I can sync #439 again with main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Brings
geofencing-subscriptionsto Commonalities 0.9.0 (r4.4):x-camara-commonalitiesand re-syncs theadditional-error-responsestemplate.Generic<status>responses and local copies with the r4.4 catalogue andCAMARA_event_common.yamlresponses, following the r4.4 subscription template. Where the extra codes of a response cannot occur, the narrower catalogue response is used:BadRequest400on the list operation and the notification callback,TooManyRequests429on the callback.CreateSubscriptionUnprocessableEntity422(a deprecated common name in r4.4) toCreateGeofencingSubscriptionDevice422: the codes of the commonCreateSubscriptionDevice422plus the twoGEOFENCING_SUBSCRIPTIONS.*codes.TooManyRequestsWithQuota429on create, as no catalogue response declares bothTOO_MANY_REQUESTSandQUOTA_EXCEEDED.ConfigBase, references the commonSink,ErrorInfoandSubscriptionPermissionDenied403directly, and removes unused or pass-through local aliases.GEOFENCING_SUBSCRIPTIONS.*examples stay inline.#/prefix.Locally defined error responses drop from 10 to 2.
Which issue(s) this PR fixes:
Fixes #435
Special notes for reviewers:
0.y.z; last public version0.5.0,0.6.0so far only shipped as rc):CreateSubscriptionBadRequest400, which addsOUT_OF_RANGE(reachable via range-constrained properties such assubscriptionMaxEventsandradius).MULTIEVENT_COMBINATION_TEMPORARILY_NOT_SUPPORTED. Like the already declaredMULTIEVENT_SUBSCRIPTION_NOT_SUPPORTEDit cannot occur whiletypeshasmaxItems: 1; declaring both now keeps a later relaxation ofmaxItemsnon-breaking.OUT_OF_RANGEon the list and callback 400,QUOTA_EXCEEDEDon the callback 429) affects no client.$refs lose their localsummary:— the pool examples carrydescriptiononly.P-027/S-211in the other two specs (fix: align location-retrieval and location-verification with Commonalities r4.4 #436) andG-004/S-313, deferred in [geofencing-subscriptions] Deferred validation findings for r4.1 — G-004 scenario count #422. Test follow-ups: [geofencing-subscriptions] Test definitions: OUT_OF_RANGE coverage and multievent scenario vs maxItems: 1 #438.Changelog input
Additional documentation
This section can be blank.