Skip to content

fix(geofencing-subscriptions): align with Commonalities r4.4 - #437

Merged
hdamker merged 8 commits into
camaraproject:mainfrom
hdamker:fix/commonalities-r4.4-geofencing-subscriptions
Sep 27, 2026
Merged

hdamker merged 8 commits into
camaraproject:mainfrom
hdamker:fix/commonalities-r4.4-geofencing-subscriptions

Conversation

@hdamker

@hdamker hdamker commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

correction

What this PR does / why we need it:

Brings geofencing-subscriptions to Commonalities 0.9.0 (r4.4):

  • Bumps x-camara-commonalities and re-syncs the additional-error-responses template.
  • Replaces the deprecated Generic<status> responses and local copies with the r4.4 catalogue and CAMARA_event_common.yaml responses, following the r4.4 subscription template. Where the extra codes of a response cannot occur, the narrower catalogue response is used: BadRequest400 on the list operation and the notification callback, TooManyRequests429 on the callback.
  • Renames CreateSubscriptionUnprocessableEntity422 (a deprecated common name in r4.4) to CreateGeofencingSubscriptionDevice422: the codes of the common CreateSubscriptionDevice422 plus the two GEOFENCING_SUBSCRIPTIONS.* codes.
  • Keeps a local TooManyRequestsWithQuota429 on create, as no catalogue response declares both TOO_MANY_REQUESTS and QUOTA_EXCEEDED.
  • Extends the common ConfigBase, references the common Sink, ErrorInfo and SubscriptionPermissionDenied403 directly, and removes unused or pass-through local aliases.
  • Error examples reference the shared example pools; only the GEOFENCING_SUBSCRIPTIONS.* examples stay inline.
  • Normalises the OAS pointers in the feature file to the #/ prefix.

Locally defined error responses drop from 10 to 2.

Which issue(s) this PR fixes:

Fixes #435

Special notes for reviewers:

Changelog input

fix(geofencing-subscriptions): align with Commonalities r4.4
BREAKING: createGeofencingSubscription declares two additional error codes, 400 OUT_OF_RANGE and 422 MULTIEVENT_COMBINATION_TEMPORARILY_NOT_SUPPORTED

Additional documentation

This section can be blank.

docs

@hdamker hdamker added correction Sync26 In scope for Sync26 Meta-release labels Sep 23, 2026
@hdamker
hdamker marked this pull request as draft September 24, 2026 07:55
@hdamker

hdamker commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

@camaraproject/device-location_codeowners

Updated the PR after an own review with two commits (ba2090e, c08a73d) and updated the description accordingly. Now again ready for review.

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker

hdamker commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Merging so that I can sync #439 again with main.

@hdamker
hdamker merged commit 5d8c33e into camaraproject:main Sep 27, 2026
2 checks passed
@hdamker
hdamker deleted the fix/commonalities-r4.4-geofencing-subscriptions branch September 27, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction Sync26 In scope for Sync26 Meta-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align geofencing-subscriptions with Commonalities r4.4

3 participants