Repository navigation
Improve test-definitions regarding style, structure and format - #331
Merged
jlurien merged 34 commits intoSep 2, 2025
Merged
Conversation
… location-retrieval.feature & location-verification.feature
maxl2287
added
tests
jlurien
reviewed
Jun 3, 2025
jlurien
left a comment
jlurien
left a comment
Collaborator
There was a problem hiding this comment.
Some comments, still need to fully review geofencing-subscriptions
Collaborator
|
Geofencing test plan should be aligned with the outcome of camaraproject/Commonalities#470. |
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Collaborator
|
@maxl2287 I would keep this open until camaraproject/Commonalities#470 is merged and then review that is totally aligned, wdyt? |
maxl2287
marked this pull request as draft
June 18, 2025 07:45
…definitions # Conflicts: # code/Test_definitions/geofencing-subscriptions.feature # code/Test_definitions/location-retrieval.feature
maxl2287
marked this pull request as ready for review
June 18, 2025 20:35
Contributor
Author
jlurien
reviewed
Aug 22, 2025
jlurien
reviewed
Aug 26, 2025
jlurien
left a comment
jlurien
left a comment
Collaborator
There was a problem hiding this comment.
It seems that geofencing-subscriptiuons.feature is not aligned yet with https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.feature
…definitions # Conflicts: # code/Test_definitions/geofencing-subscriptions.feature # code/Test_definitions/location-retrieval.feature # code/Test_definitions/location-verification.feature
jlurien
reviewed
Aug 28, 2025
jlurien
left a comment
jlurien
left a comment
Collaborator
There was a problem hiding this comment.
Review that stabdar error scenarios are aligned with https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.feature
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
jlurien
previously approved these changes
Sep 2, 2025
jlurien
left a comment
jlurien
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with 3 corrections that I can apply directly
jlurien
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Improve test-definitions for geofencing-subscriptions.feature, location-retrieval.feature & location-verification.feature
Which issue(s) this PR fixes:
Fixes #330
Changelog input