Skip to content

[Changed] Refactor MatchRequestBody‎ to allow proper schema validation for provided identifier - #202

Merged
eric-murray merged 22 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-1
Aug 27, 2026
Merged

eric-murray merged 22 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-1

Conversation

@eric-murray

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • correction

What this PR does / why we need it:

  • Defines schemas for IMEI, IMEISV, TAC and PPID
  • Refactors MatchRequestBody‎ to require exactly one of imei, imeisv, tac be provided, plus optional device
  • Updated test cases

Which issue(s) this PR fixes:

Fixes #195

Special notes for reviewers:

None

Changelog input

 release-note
 - Refactor MatchRequestBody‎ to allow proper schema validation for provided identifier

Additional documentation

None

@eric-murray
eric-murray requested a review from Kevsy as a code owner August 27, 2026 12:05
Kevsy
Kevsy previously approved these changes Aug 27, 2026

@Kevsy Kevsy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray eric-murray changed the title Refactor MatchRequestBody‎ to allow proper schema validation for provided identifier [Changed] Refactor MatchRequestBody‎ to allow proper schema validation for provided identifier Aug 27, 2026

@Kevsy Kevsy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray
eric-murray merged commit 5dcccd7 into camaraproject:main Aug 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing test coverage for device disambiguation, consent denial, and identifier-type/length validation

2 participants