Repository navigation
Use int32-range bounds for arrays and device counters (#145) - #196
Open
jimfengjinhua wants to merge 1 commit into
Open
jimfengjinhua wants to merge 1 commit into
jimfengjinhua wants to merge 1 commit into
Conversation
) Arrays: - Set maxItems of the AccessDevices and Devices base schemas from 9007199254740991 to the int32 maximum (2147483647). - Narrow every use of them to the operative bound: the listAccessDevices page (AccessDevicesPage.items) now has minItems 0 / maxItems 100, matching perPage (maximum 100) and the other page arrays. AddedAccessDevices, CreateAccessRequest and AddDevicesRequest already narrow to minItems 1 / maxItems 100. Device counters: - Change AccessStats.totalDevices, totalGranted and totalDenied and NetworkProfile.maxNumberOfDevices from int64 (maximum 9007199254740991) to int32 (maximum 2147483647), in line with the Commonalities TotalCount, which counts the same devices in the listAccessDevices pagination. The other bounds listed in the issue were already set to 100 by the pagination changes.
jimfengjinhua
requested review from
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
October 8, 2026 15:11
tlohmar
approved these changes
Oct 9, 2026
tlohmar
left a comment
tlohmar
left a comment
Contributor
There was a problem hiding this comment.
As agreed. Lets first go with in32 and expand, when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Arrays:
Device counters:
Which issue(s) this PR fixes:
Fixes #145
Special notes for reviewers:
The other bounds listed in the issue were already set to 100 by the pagination changes.
Changelog input
Additional documentation
This section can be blank.