Repository navigation
Add sunny day test definitions for networks, areas and profiles APIs - #178
Merged
tlohmar merged 1 commit intoSep 10, 2026
Merged
Conversation
Adds success scenarios covering documented behaviour that had no test coverage: name filtering and pagination for listNetworks and readNetworkProfiles, pagination and combined (AND) filtering for retrieveNetworkServiceAreas, and createNetwork via qosProfileName and with the optional name property
jimfengjinhua
requested review from
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
September 4, 2026 09:07
tlohmar
approved these changes
Sep 7, 2026
tlohmar
left a comment
tlohmar
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Good that we can also test pagination.
jimfengjinhua
added a commit
to jimfengjinhua/DedicatedNetworks
that referenced
this pull request
Sep 10, 2026
Brings in the sunny day test definitions merged via PR camaraproject#178 so this branch is up to date with main. No conflicts: the success scenarios added on main and the error scenarios added here touch disjoint regions of the three feature files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds success ("sunny day") test definitions for documented API behaviour that
currently has no coverage in the feature files:
dedicated-network.feature
listNetworks_02_success_filtered_by_name— thenamequery parameterlistNetworks_03_success_pagination—perPage/page, thepaginationobject and the
X-Total-Count/X-Total-Pages/Linkresponse headerscreateNetwork_03_success_with_qos_profile_name— theqosProfileNamebranch of the
CreateNetworkoneOf, which was untested (onlynetworkProfileIdwas covered)createNetwork_04_success_with_name— the optionalnamepropertydedicated-network-areas.feature
retrieveNetworkServiceAreas_09_success_filtered_by_several_properties_first_page—
RetrieveServiceAreasRequestis documented as retrieving areas that matchall the given properties, but every existing scenario passes a single filter
retrieveNetworkServiceAreas_10_success_paginationdedicated-network-profiles.feature
readNetworkProfiles_02_success_filtered_by_namereadNetworkProfiles_03_success_paginationWhich issue(s) this PR fixes:
Adress #176
Special notes for reviewers:
Test definitions for the accesses API are deliberately out of scope, as that API is still under development.
Changelog input
Additional documentation
This section can be blank.